This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#7264 - Build with -Os switch for coldfire targets.
Attached to Project:
Rockbox
Opened by Nils Wallménius (nls) - Thursday, 07 June 2007, 12:14 GMT+2
Last edited by Nils Wallménius (nls) - Wednesday, 13 June 2007, 17:36 GMT+2
Opened by Nils Wallménius (nls) - Thursday, 07 June 2007, 12:14 GMT+2
Last edited by Nils Wallménius (nls) - Wednesday, 13 June 2007, 17:36 GMT+2
|
DetailsThis patch has a few different pieces.
0) Change the configure script to enable the -Os switch for m68k-elf-gcc. 1) It adds wrapper functions for memcpy and memset to some plugins to allow gcc to use those functions when optimizing. 2) Some small changes to playback_control to avoid memcpy here. 3) In playback.c change voicebuf to be unsigned char and adapt callbacks to this and make them accept the size parameter as size_t. Both these changes were to avoid casting which made gcc throw a warning about dereferencing type-punned pointers. Size drops about 20kb for rockbox.iriver for h300 builds. I tested a build on my player and everything works as far as i can see. Test built for a number of other targets without errors too. I would like if some playback guru out there could take a look at this to see if my changes seem ok, i'm not very confident with changing playback.c and mp3_playback.c... I tried to build with -O2 too but it fails on IRAM_FULL for the nsf codec. 
os.diff
(12.5 KiB)
tools/configure | 5 +++++ apps/plugins/mp3_encoder.c | 6 ++++++ apps/plugins/xobox.c | 5 +++++ apps/plugins/video.c | 2 +- apps/plugins/battery_bench.c | 6 ++++++ apps/plugins/jpeg.c | 12 ++++++++++++ apps/plugins/lib/playback_control.c | 9 +++++---- apps/plugins/mazezam.c | 6 ++++++ apps/plugins/metronome.c | 8 +++++++- apps/plugins/blackjack.c | 6 ++++++ apps/plugins/chip8.c | 2 +- apps/plugins/chessclock.c | 6 ++++++ apps/plugins/rockpaint.c | 12 ++++++++++++ apps/plugins/properties.c | 6 ++++++ apps/talk.c | 4 ++-- apps/playback.c | 10 +++++----- apps/plugin.h | 2 +- firmware/export/mp3_playback.h | 2 +- firmware/mp3_playback.c | 6 +++--- firmware/mpeg.c | 2 +- 20 files changed, 97 insertions(+), 20 deletions(-) |
This task depends upon
* change the voice_info struct to have the same types as voicebuf and the size parameters to get rid of some uglyness
* bumped plugin api
Would really like to get someone else to test this, both on coldfire and archos targets
and some plaback.c guru to take a quick look at the changes in there too.
in a new file apps/plugins/lib/mem_function_wrappers.h
and put this in every plugin that needed it.
init function to point the api pointer correctly (like in playback_control.c for example).
Doing that worked fine but if I did not do it the linker didn't complain because the plugins
are linked against everything in the plugin lib and the plugins just froze when they were run.
The bad thing is that gcc decides itself which plugins should use the mem* functions and some
arbitrary change might trigger it which then will cause the plugin to freeze, not nice.
A workaround would be to add the init call to every plugin but I thought this was nicer.
I would like to hear suggestions on how to make it better though
I added
../../../firmware/common/memcpy.c
../../../firmware/common/memset.c
to the end of apps/plugins/lib/SOURCES
and everything compiled fine but plugins using any of the two functions froze when started...
as a test I also copied the .c files to the lib dir and changed SOURCES accordingly but with the same result.
Is it worth it to continue trying to make that work or should we go with one of the other ways?