Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7272 - Fix loss of voice menus if powered off during recording.

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 08 June 2007, 10:02 GMT+2
Last edited by Steve Bavin (pondlife) - Monday, 11 June 2007, 10:28 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As per  FS#6163 , currently recording disables voice menus by modifying the settings at the start and restoring it at the end. This means that if you shutdown during recording, the voice menus are disabled when you power up again. This causes problems for visually impaired users.

The attached patch adds routines to talk.c to allow voice menus to be temporarily disabled without updating any persisted settings. Please test if you use voice menus, especially if you do lots of recording.
   temporary_voice_disable.patch (10.2 KiB) 
 apps/screens.c            |    4 ++--
 apps/recorder/keyboard.c  |   10 +++++-----
 apps/recorder/recording.c |   18 +++++++++---------
 apps/settings.c           |   11 ++++++-----
 apps/menu.c               |    2 +-
 apps/menus/main_menu.c    |    5 +++--
 apps/talk.c               |   18 ++++++++++++++++++
 apps/talk.h               |    4 +++-
 apps/player/keyboard.c    |    6 +++---
 apps/bookmark.c           |    2 +-
 10 files changed, 51 insertions(+), 29 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Monday, 11 June 2007, 10:28 GMT+2
Reason for closing:  Accepted

Loading...