Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7294 - Use PNGs for buttons

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Tuesday, 12 June 2007, 16:45 GMT+2
Last edited by Jonas Häggqvist (rasher) - Saturday, 23 June 2007, 04:40 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes Rockbox Utility to use PNGs for the buttons. This has the advantage of allowing much nicer graphics. Right now, the image loading is implemented using external files, but it should certainly be possible to embed them in the executable.

http://wxwidgets.org/wiki/index.php/Embedding_PNG_Images Explains how to convert PNGs to C and then use them like that.

http://www.wxwidgets.org/manuals/stable/wx_wxbitmap.html#wxbitmap Says that images can either be loaded from file or a resource, but I don't know how resources work.

The next problem is I've taken icons from the Tango Desktop project. These icons are available under the Creative Commons Attribution-ShareAlike 2.5 License, which is not GPL compatible so more suitable icons should be found for embedding into the executable.
   rbutil-pngbuttons.patch (3.5 KiB) 
 rbutilFrm.cpp |   23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

   buttons.tar.bz2 (21.7 KiB)
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Saturday, 23 June 2007, 04:40 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Added to SVN (in a proper version) it seems.
Comment by Jonas Häggqvist (rasher) - Tuesday, 12 June 2007, 17:27 GMT+2
Here's a set of buttons based on gnome-icon-theme, which is licensed under GPL, but looks pretty similar to the "official" tango icons, since they're based on the same guidelines.

Of course, using the Doom logo is probably not too wise either...
   gnome-icon-theme-buttons.tar.bz2 (22.4 KiB)
Comment by Dominik Wenger (Domonoky) - Friday, 15 June 2007, 23:26 GMT+2
i think we have to embedd those image into the binary, otherwise there are to many needed files.

Afaik loading images from resources is only possible in Winodows, so we should convert those images to C with the bin2c program as it is explained in the first link you gave.

And we should change the doom image..
Comment by Jonas Häggqvist (rasher) - Tuesday, 19 June 2007, 23:04 GMT+2
I agree on all three points, but won't have time to look at this anytime soon.

The best solution would probably be to convert the PNGs at build-time, so the PNGs could be kept as the originals.

For the doom image, I suppose we could use a generic "games" icon from the gnome set (I believe it's a joystick).

Loading...