Rockbox

Tasklist

FS#7325 - Peak Meter: Bug when switching from linear to logarithmic scale.

Attached to Project: Rockbox
Opened by PaulJam (PaulJam) - Monday, 18 June 2007, 17:05 GMT
Last edited by Peter D'Hoye (petur) - Sunday, 24 June 2007, 00:20 GMT
Task Type Bugs
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

See also: http://forums.rockbox.org/index.php?topic=10842.0
When the peakmeter is set to linear scale and "Minimum of Range" is set to 0% and you then set the scale to logarithmic, then both, Minimum and Maximum of Range have the same value.
In the config.cfg the value for "peak meter min" is then set to 92, but in the settings the minimum value you can set it to is -89dB (which would be stored as 89 in the config.cfg).

A possible fix would propably be to set the value to -89dB if it is smaller when switching to logarithmic (in apps/menus/display_menu.c around line 428)

An in my opinion better fix would it be to store the min/max values sepearately for logarithmic ang linear scale in the config.cfg instead of recalculating them when switching the scale.

H300 with r13666
This task depends upon

Closed by  Peter D'Hoye (petur)
Sunday, 24 June 2007, 00:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  I only saw your suggested fix after I fixed and committed.

Loading...