Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7327 - Minesweeper Button Changes

Attached to Project: Rockbox
Opened by Alexander Papst (DerPapst) - Monday, 18 June 2007, 21:46 GMT+2
Last edited by Marianne Arnold (pixelma) - Monday, 25 June 2007, 22:42 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes the button layout in Minesweeper for all iPods, iAudio and Sansa E2XX.

The initial version of this patch was made by pixelma (iAudio and parts of the iPod layout) and i've added the abillity to scroll through the entire filed with the scroll wheel of the iPod and the Sansa.
   minesweeper_buttons.patch (3.1 KiB) 
 apps/plugins/minesweeper.c |   51 +++++++++++++++++++++++++++++++++------------
 1 file changed, 38 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Marianne Arnold (pixelma)
Monday, 25 June 2007, 22:42 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed the manual part (though with a few changes).
Comment by Alexander Papst (DerPapst) - Monday, 18 June 2007, 23:19 GMT+2
Forgot to add the describtion of the new button layout:

iPod
====
UP: Menu
Down: Play/Pause
Left: <<
Right: >>
Set a flag: Select
Reveal the contents of the current square: Long press Select
Show Info: Select + Play/Pause
Quit: Menu + Select
Scroll through the entire filed with the wheel.

iAudio
======
Show Info: Long press Record

Sansa
=====
Scroll through the entire field with the wheel.

I've added the changes to the manual too. But i know nothing about latex so i'm not sure if my changes break anything in the manual.
   minesweeper_buttons_manual.patch (2.5 KiB) 
 manual/plugins/minesweeper.tex |   20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

Comment by Marianne Arnold (pixelma) - Wednesday, 20 June 2007, 13:05 GMT+2
- fixed the issue in the Ipod keypad definition that caused it to toggle the flag too when calling the info screen (which also has to be corrected).
- using the scrollwheel as an alternative seems to work fine in the sim (it's my only possibility to test).
- basically redid the manual patch as it didn't apply cleanly at all - also put the description of the scrolling on it's on line in the table - looks better and makes sense IMO.
- removed those nasty tabs...

I'd like to have some (more) opinions of Ipod users before a commit. So please test :)
   minesweeper_buttons_2.patch (3.2 KiB) 
 apps/plugins/minesweeper.c |   54 +++++++++++++++++++++++++++++++++------------
 1 file changed, 40 insertions(+), 14 deletions(-)

   minesweeper_buttons_manual_2.patch (1.9 KiB) 
 manual/plugins/minesweeper.tex |   15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

Comment by Jens Arnold (amiconn) - Monday, 25 June 2007, 20:41 GMT+2
Committed the code part

Loading...