Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7379 - Rockboy sound patch

Attached to Project: Rockbox
Opened by Karl Kurbjun (kkurbjun) - Saturday, 30 June 2007, 22:29 GMT+2
Last edited by Karl Kurbjun (kkurbjun) - Saturday, 21 July 2007, 06:04 GMT+2
Task Type Patches
Category Games
Status Closed
Assigned To Karl Kurbjun (kkurbjun)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is a patch for rockboy that attempts to clean up the sound by adding in sound code from VisualBoy. If you test this please let me know the results including the player used and the game played.
This task depends upon

Closed by  Karl Kurbjun (kkurbjun)
Saturday, 21 July 2007, 06:04 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Patch committed to SVN - sound will be different on players that cannot emulate full speed (sound buffers are not improperly repeated any more)
Comment by Karl Kurbjun (kkurbjun) - Saturday, 30 June 2007, 22:31 GMT+2
Forgot the file
   rbdiff.diff (7.5 KiB) 
 apps/plugins/rockboy/sound.c   |  125 ++++++++++++++++++++++++-----------------
 apps/plugins/rockboy/sound.h   |    2 
 apps/plugins/rockboy/rbsound.c |   13 +++-
 3 files changed, 88 insertions(+), 52 deletions(-)

Comment by Alexander Spyridakis (xaviergr) - Sunday, 01 July 2007, 01:17 GMT+2
Plays excellent on my F40. Tremendous difference from the current one in SVN.
Choppy on H300 but that's because it can't get more than 50+ fps.
Comment by Benjamin Lebsanft (Benjamin_L) - Sunday, 01 July 2007, 13:25 GMT+2
Still choppy on the sansa but better than before.
Comment by Peter D'Hoye (petur) - Friday, 13 July 2007, 19:18 GMT+2
/me wonders why this isn't making it into svn...
Comment by nick (deathdr0ne) - Friday, 13 July 2007, 23:33 GMT+2
will test on ipod 64mb "60GB" model, and get back to you.
Comment by Travis Tooke (tdtooke) - Saturday, 21 July 2007, 01:16 GMT+2
I've tested this on my iPod 30g 5.5g and I'm not sure if it has improved the sound, but it's still definitely worse than before they commited that rockboy sound change recently. I'm toying with the idea of taking this patch and merging it with another that basically throws alotta ifdefs in so some of the changes recently committed are undone if the target is an iPod. I'm quite some ways from actually being able to do that, since that would involve tracking down exactly what change killed the sound on the iPod, but it's a thought.
Comment by Karl Kurbjun (kkurbjun) - Saturday, 21 July 2007, 04:27 GMT+2
Here is a newer version of the patch, this is an almost complete rewrite of the sound core based on visualboy advance.
   rocksound.diff (29.4 KiB) 
 rockmacros.h |    1 
 sound.c      |  941 +++++++++++++++++++++++++++++++++++++++--------------------
 sound.h      |   35 +-
 rbsound.c    |   13 
 mem.h        |    1 
 5 files changed, 670 insertions(+), 321 deletions(-)

Loading...