This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#7440 - Remove (non-functional) hardware equalizer on iPod
Attached to Project:
Rockbox
Opened by Dan Everton (safetydan) - Sunday, 15 July 2007, 13:08 GMT+2
Last edited by Dan Everton (safetydan) - Saturday, 24 November 2007, 08:58 GMT+2
Opened by Dan Everton (safetydan) - Sunday, 15 July 2007, 13:08 GMT+2
Last edited by Dan Everton (safetydan) - Saturday, 24 November 2007, 08:58 GMT+2
|
DetailsThe attached patch removes the hardware equalizer menu from the iPod Video settings. It does keep the low-shelf and high-shelf filter settings but moves those to a bass and treble cutoff setting in the sound settings menu. Also, the bass and treble settings in the sound settings menu are replaced with the hardware eq equivalents.
Unfortunately I haven't tested this on target as I don't have an iPod Video to use. 
wm8758_hwaudio.diff
(19.9 KiB)
apps/lang/english.lang | 28 +++++++ apps/settings.c | 5 + apps/settings.h | 27 +------ apps/menus/eq_menu.h | 11 -- apps/menus/eq_menu.c | 153 ---------------------------------------- apps/menus/sound_menu.c | 18 +++- apps/settings_list.c | 65 ++-------------- apps/playback.c | 7 - firmware/export/audiohw.h | 4 + firmware/export/wm8758.h | 2 firmware/sound.c | 4 + firmware/drivers/audio/wm8758.c | 46 ++++-------- 12 files changed, 87 insertions(+), 283 deletions(-) |
This task depends upon
Closed by Dan Everton (safetydan)
Saturday, 24 November 2007, 08:58 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed.
Saturday, 24 November 2007, 08:58 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed.
The hardware equalizer and the bass/treble settings produce different results!
The bass/treble settings on the sound menu does have bugs, but using the hardware equalizer clips the sound, making bass sound really fuzzy and crap!
And no, I'm not confusing this with the "software equalizer".
I prefer to use the bass/treble settings on the sound menu (even though the sound volume actually increases while using them) rather than linking them to the poorly designed hardware. unless there can be confirmation that the bad quality sound achieved using the hardware equalizer is not passed on to the settings in the 'bass/treble settings'.
If not, then I fully support this patch, as it possibly fixes the volume problem I filed on
FS#7427Any EQ will clip your sound if your volume isn't low enough, and this one is no exception. The SW EQ is actually worse at this unless you don't use the precut, at least the hardware EQ won't clip your sound unless you have the volume close to 0 dB.
Someone should really finish this and commit it.
I would...but I don't have the time or experience
Firstly, I'm aware that the cut-off frequencies quoted in the datasheet are unlikely to be accurate at different samplerates, but I don't like the use of "0", "1", "2" and "3". I'm sure we'll get lots of complaints/queries about that. But I also can't think of anything better...
There does seem to be a problem with the patch though - if I change the bass gain, then go to the bass cutoff screen and change the bass cutoff, then the bass gain is reset to 0. Going back to the bass gain shows the previous value selected, but it's no longer applied.
The same problem appears to happen with the treble.
I was unable to reproduce the issues with the gain resetting in the simulator.