Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7469 - midiplay quick fix

Attached to Project: Rockbox
Opened by tyama (tyama) - Sunday, 22 July 2007, 19:55 GMT+2
Last edited by Nils Wallménius (nls) - Friday, 05 October 2007, 01:29 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This will fix:
1.Some files show "Buffer miss!"
2.Playbacks were twice as fast as normal midi players.

But I could not fix "Undefined instruction at 03F804D8"...
   midiplay.patch (1.3 KiB)
 midiplay\midiplay.c |   11 +--!!!!!!!!
 1 file changed, 1 insertion(+), 2 deletions(-), 8 modifications(!)

This task depends upon

Closed by  Nils Wallménius (nls)
Friday, 05 October 2007, 01:29 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  This is obsolete after recent changes to midiplayer
Comment by Linus Nielsen Feltzing (linusnielsen) - Sunday, 22 July 2007, 20:11 GMT+2
What platforms have you tested this on? I'm pretty sure that most platforms won't be able to play more than a few channels at 44.1kHz sample rate.
Comment by tyama (tyama) - Sunday, 22 July 2007, 20:30 GMT+2
I have tested on iPod 5.5g 80GB...
Comment by tyama (tyama) - Sunday, 22 July 2007, 20:49 GMT+2
Sorry, I think my first patch took too much memory.
   midiplay.patch (1.3 KiB)
 midiplay\midiplay.c |    9 +--!!!!!!
 1 file changed, 1 insertion(+), 2 deletions(-), 6 modifications(!)

Comment by tyama (tyama) - Sunday, 22 July 2007, 21:10 GMT+2
I think you are right. I'm really sorry.
   midiplay.patch (1.5 KiB)
 midiplay\midiplay.c      |    7 +--!!!!
 midiplay\midi\midifile.c |    2 ++
 2 files changed, 3 insertions(+), 2 deletions(-), 4 modifications(!)

Loading...