This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#7555 - Add Double-Click button press (currently enabled for Ipod Video only)
Attached to Project:
Rockbox
Opened by John K (yegods) - Tuesday, 07 August 2007, 22:21 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 15 May 2008, 16:38 GMT+2
Opened by John K (yegods) - Tuesday, 07 August 2007, 22:21 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 15 May 2008, 16:38 GMT+2
|
DetailsAlthough this patch is specifically for the Ipod Video... there isn't any reason that it won't work for other players. Changing the configure script and keymap file are about all that needs to be done to add it.
I have created a patch to the button firmware that will allow double-clicks to be caught and processed. It's a little complex, and though i have done quite a bit of testing, there are probably some small problems. it would be great if some of you could give this a whirl, and see if there are any major flaws. i have a couple patches that i'll be adding shortly, that will make use of the patch. if you want to enable the patch follow these steps: 1) download attached patch file (it is created for the latest revision: 14233) 2) apply patch 3) run tools/configure in your build directory 4) build now if it builds successfully, you can start using double clicks. this will entail the following steps: 1) modify apps/keymaps/keymap_ipod.c to add the double click to any actions you want. format is as such: this will add a double click for the select button in the wps page... #ifdef ACCEPT_DOUBLE_CLICK { <action define>, BUTTON_SELECT | BUTTON_REL, BUTTON_SELECT | BUTTON_DBL } #endif always put the double click actions before any other actions in the section. if you want to enable this for other players, modify the player configuration section in the configure script to have the folowing line: extradefines="$extradefines -DACCEPT_DOUBLE_CLICK" modify your players keymap file in the same way as described above of the Ipod Video. rerun the build. |
This task blocks these from closing
FS#7571 - Queue Track Album, Skip Album, Rewind Album -- for Ipod, uses Do
Closed by Jonathan Gordon (jdgordon)
Thursday, 15 May 2008, 16:38 GMT+2
Reason for closing: Rejected
Additional comments about closing: sorry, double click just slows down an already slow UI
Thursday, 15 May 2008, 16:38 GMT+2
Reason for closing: Rejected
Additional comments about closing: sorry, double click just slows down an already slow UI
FS#7716is in the last patch, which causes problems when compiling (for those who don't have that patch)FS#7762(scrub mode ff/rew for iPod).This uses your double click feature - and it works great! I was looking for a way to activate scrub mode, but most of the easy ways are already used. Double click was just what I needed.
Let me know what you think.
if you have a suggestion for how to disable double-clicks while in a plugin, then i'd be glad to implement it. i'm not really sure how to do that, except by maybe undefining the double click define for every plugin. seems a lot of work though.
Would it be possible to have different settings like "Ignore 'The'" patch has in File Browser? For example, the user could choose the following settings:
[b]Double-clicks[/b]
Disabled
Audio playback features only
All screens