Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7561 - Say the time in 12 hour format

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Wednesday, 08 August 2007, 23:35 GMT+2
Last edited by Jonas Häggqvist (rasher) - Wednesday, 22 August 2007, 00:55 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Voice the time in 12 hour format under the info screen. It even says a m and pm. In english.lang I had to write a m so it wouldn't say am. Anyway here it is.
   time_12_hour.diff (2.7 KiB) 
 apps/lang/english.lang |   51 +++++++++++++++++++++++++++++++++++++
 apps/menus/main_menu.c |   67 ++++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 115 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Wednesday, 22 August 2007, 00:55 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r14418. Thanks.
Comment by Daniel Dalton (ddalton) - Friday, 10 August 2007, 08:35 GMT+2
just a bit of an update.

allows the time to be voiced in 12 or 24 hour. Just change the setting in /settings/general settings/system/time/time format to how you want it to be displayed and voiced.

A couple of things:
Removed the ability to voice the secconds. This is very easy to add again so let me know if you want it added. I couldn't see how you would say the time in 12 hour format with secconds. Would you like it to say seven forty four and seven seconds pm? or "seven forty four pm and seven secconds" so let me know. I removed it from the 24 hour clock as well.
This only effects the voice.

Also the indentation is wrong. I am looking into linux and a better text editor. so If you want you can fix the indentation. Anyway here it is.
   time_with_setting.diff (7.3 KiB) 
 apps/lang/english.lang |   51 +++++++++++++++++++++++++++++++++
 apps/menus/main_menu.c |   75 +++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 123 insertions(+), 3 deletions(-)

Comment by Bryan Childs (GodEater) - Friday, 10 August 2007, 09:26 GMT+2
I fixed the indenting here.
   time_with_setting.diff (4.5 KiB) 
 b/apps/lang/english.lang |   51 +++++++++++++++++++++++++++++++++
 b/apps/menus/main_menu.c |   71 ++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 121 insertions(+), 1 deletion(-)

Comment by Daniel Dalton (ddalton) - Saturday, 11 August 2007, 15:09 GMT+2
Just cleaned up the code a bit. So it is easier to read and not as long. Also I haven't tested it but it should work. If it doesn't I will post an update tomorrow. Also noone has said anything about the seconds being removed so I think I will just keep it this way. I don't really have a need to here the settings.

Here it is...
   time_updated.patch (3.4 KiB) 
 apps/lang/english.lang |   51 +++++++++++++++++++++++++++++++++++++++++++++++++
 apps/menus/main_menu.c |   38 +++++++++++++++++++++++++++++++++++-
 2 files changed, 88 insertions(+), 1 deletion(-)

Comment by Daniel Dalton (ddalton) - Sunday, 12 August 2007, 11:23 GMT+2
I fixed up the patch. It didn't work before. So just made some small changes.
Also in my last comment I meant I don't have a need to here the seconds voiced.

Anyway here it is again. Sorry about the confusion.
   time_fix.patch (3.6 KiB) 
 apps/lang/english.lang |   51 +++++++++++++++++++++++++++++++++++++++++++++++++
 apps/menus/main_menu.c |   42 +++++++++++++++++++++++++++++++++++++---
 2 files changed, 90 insertions(+), 3 deletions(-)

Comment by Daniel Dalton (ddalton) - Sunday, 12 August 2007, 13:34 GMT+2
Just cleaned up the code a bit.
Removed a comment and used and else instead of another if.

Here it is...
   time.diff (3.5 KiB) 
 apps/lang/english.lang |   51 +++++++++++++++++++++++++++++++++++++++++++++++++
 apps/menus/main_menu.c |   41 ++++++++++++++++++++++++++++++++++++---
 2 files changed, 89 insertions(+), 3 deletions(-)

Loading...