Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7653 - Say file type

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Saturday, 25 August 2007, 05:43 GMT+2
Last edited by Stephane Doyon (sdoyon) - Wednesday, 07 November 2007, 02:45 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

In the file browser, when spelling of directory or file names is enabled,
say the file type (or "folder") before spelling. Allows to browse much
faster because you can quickly skip over files of the wrong
type. Controlled by a setting so you can leave it off if you don't like
it.

Also if you have ".talk mp3 clip" enabled and a directory name was
spoken, it then says "folder" (afterwards), just to make it clearer.

This was originally a secondary feature in P#6236, which was closed
because something equivalent to its main function was committed.

In my view, this makes the slow spelling much less annoying, because you
can discriminate and so you get to hear a lot less of it.
   say-filetype.diff (6.9 KiB) 
 trunk/apps/lang/english.lang     |   14 +++++++++
 trunk/apps/menus/settings_menu.c |    4 ++
 trunk/apps/settings.h            |    1 
 trunk/apps/settings_list.c       |    1 
 trunk/apps/tree.c                |   58 +++++++++++++++++++++++++++++++++------
 5 files changed, 69 insertions(+), 9 deletions(-)

This task depends upon

Closed by  Stephane Doyon (sdoyon)
Wednesday, 07 November 2007, 02:45 GMT+2
Reason for closing:  Accepted
Comment by Daniel Dalton (ddalton) - Sunday, 26 August 2007, 05:34 GMT+2
This is a good patch.
Just one question.
When .talk clips are enabled can it speak the file exstention?
So for example if I scrol over a text file called file.txt can it say file from the .talk clip and then say .txt from the voice file.

But I think this is a really useful patch. The only thing that might stop it been committed is the extra setting. I don't think it is too much so I can't see why it can't be committed.
Thanks.
Comment by Stephane Doyon (sdoyon) - Thursday, 13 September 2007, 04:57 GMT+2
>This is a good patch.
>Just one question.
>When .talk clips are enabled can it speak the file exstention?
>So for example if I scrol over a text file called file.txt can it say file
>from the .talk clip and then say .txt from the voice file.

What would be the benefit?

My thinking was that the .talk clip already contains the voicing of
the extension. We could strip the extension when generating the .talk clips,
and speak it from the voice file, but there are disadvantages:
-There would probably be a slight delay in switching from speaking the .talk
clip to the vice file entry,
-Not all extensions are defined as file types, for example it seems .txt
isn't. We have to fallback to spelling which is slower.

>But I think this is a really useful patch. The only thing that might stop it
>been committed is the extra setting. I don't think it is too much so I can't
>see why it can't be committed.

Well I like it enabled myself and wouldn't mind not having a setting at all,
but I added the option because there seemed to be some concerns that it could
be confusing in the previous incarnation of the patch.
Comment by Daniel Dalton (ddalton) - Thursday, 13 September 2007, 08:21 GMT+2
Well here on voice box if I have a file called file.txt the voice clip says "File" then I was thinking we could have it say ".txt" so it would say "file.txt". But I can see what your saying about the delay. And I don't think one setting should be to much. Maybe we just need to bring it up in irc and hopefully get it committed.
Comment by Daniel Dalton (ddalton) - Thursday, 13 September 2007, 08:22 GMT+2
O yeah the .talk file would be called file.txt.talk.
Comment by Stephane Doyon (sdoyon) - Thursday, 13 September 2007, 15:36 GMT+2
Oh I see... I had been using a script of my own to generate .talk
clips, and I hadn't realized that the "official" script strips file
extensions by default.

tools/gentalkclips.sh has this line:
STRIP_EXTENSIONS=Y

I suppose some people might find it mor aesthetically pleasing not to
hear the extension... myself I'd rather just hear what's there. There are
settings to configure what gets displayed: for example, sighted users
can have the extensions stripped (possibly with the exception of
unrecognized ones) and have an icon shown instead.

Note that the spoken filetypes, like the icons, are more generic: it
says "audio" rather than .mp3 or .ogg or whatever. I don't think we'd
want to add more voice entries for each possible extension.

Would you want to hear "title of this song, audio",
or "title of this song dot mp3"? The second is more informative and less
confusing. Or put the type first, but that slows down browsing in a
directory full of audio files... It's good in the spelling case, not in
the .talk clips case.

I would recommend to just keep this simple: just don't strip the
extensions from the spoken name in .talk clips. Thoughts?
Comment by Stephane Doyon (sdoyon) - Friday, 14 September 2007, 04:31 GMT+2
This version applies on top of P#7775: Use list voice callback in file browser.
   say-filetype.diff (3.8 KiB) 
 trunk/apps/menus/settings_menu.c |    4 +++-
 trunk/apps/settings.h            |    1 +
 trunk/apps/settings_list.c       |    1 +
 trunk/apps/tree.c                |   13 ++++++++++++-
 trunk/apps/lang/english.lang     |   14 ++++++++++++++
 5 files changed, 31 insertions(+), 2 deletions(-)

Comment by Daniel Dalton (ddalton) - Sunday, 16 September 2007, 02:32 GMT+2
Ok I modified my copy of the voicebox script to not strip the file extensions. So don't worry about my other comments.
Comment by Stephane Doyon (sdoyon) - Saturday, 03 November 2007, 23:04 GMT+2
Updated version. I intend to commit this soon if there are no further
comments.

I have had at least one additional positive comment by private mail. It
allows to quickly skip items of the wrong type and to hear less
spelling.

Changes:

* Do not say the file type when browsing files of a specific type, as
it's redundant.

* Get rid of the setting. Let's try not to add too many new settings,
unless someone really dislikes this feature. I know two users have said
on the list that they see no reason to remove the setting, but no
argument has been made that disabling this is particularly useful.
   filetype.diff (1.1 KiB) 
 trunk/apps/tree.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Loading...