Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7712 - New codepage (CP1250 - WIN1250) added

Attached to Project: Rockbox
Opened by Przemysław Hołubowski (p.h.) - Wednesday, 05 September 2007, 09:23 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 13 October 2007, 12:33 GMT+2
Task Type Patches
Category Font/charset
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hi!

I have added a new codepage - WIN1250 (CP1250) so called "Central European" which is used by Windows users in some countries across central and eastern Europe like in Poland for example.

It enables playing files and playlists which were named using the codepage.

I have attached a patch file and a mp3 and m3u playlist files which one can use to test the new codepage. They are using polish diacritical characters from the WIN1250 codepage.
--
regards,
p.h. (przemhb)
   cp1250.patch (9.8 KiB) 
 tools/codepage_tables.c   |   19 +++++++++++++++++++
 tools/codepage_tables.h   |    1 +
 tools/codepages.c         |   22 ++++++++++++++++------
 apps/lang/polski.lang     |   14 ++++++++++++++
 apps/lang/english.lang    |   14 ++++++++++++++
 apps/plugins/viewer.c     |    2 ++
 apps/settings_list.c      |   25 +++++++++++++------------
 firmware/common/unicode.c |   11 ++++++-----
 8 files changed, 85 insertions(+), 23 deletions(-)

   _cp1250-test-ąćęńłóśźżĄĆĘŃŁÓŚŹŻ.m3u (0 KiB)
   cp1250-test-ąćęńłóśźżĄĆĘŃŁÓŚŹŻ.mp3 (44.4 KiB)
This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 13 October 2007, 12:33 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  This was committed by markun.
Comment by Przemysław Hołubowski (p.h.) - Tuesday, 25 September 2007, 00:17 GMT+2
The new version of the patch, which is included here, adds CP1250 codepage as a last one, i.e. with ID==0x08 (just after ISO8859-2).
Previous version of the patch has added it before Cyrylic CP1251, so it has changed IDs for many codepages. I was suggested by markun it would be better not to change codepages IDs, so I prepared a new version of my patch.
   cp1250.mk2.patch (8.1 KiB) 
 tools/codepage_tables.c   |   19 +++++++++++++++++++
 tools/codepage_tables.h   |    1 +
 tools/codepages.c         |   14 ++++++++++++--
 apps/plugins/viewer.c     |    2 ++
 apps/lang/polski.lang     |   14 ++++++++++++++
 apps/lang/english.lang    |   14 ++++++++++++++
 apps/settings_list.c      |   17 +++++++++--------
 firmware/common/unicode.c |   11 ++++++-----
 8 files changed, 77 insertions(+), 15 deletions(-)

Comment by Przemysław Hołubowski (p.h.) - Thursday, 27 September 2007, 21:09 GMT+2
Patch updated for the rev. 14871.
   cp1250.mk3.patch (8.1 KiB) 
 tools/codepage_tables.c   |   19 +++++++++++++++++++
 tools/codepage_tables.h   |    1 +
 tools/codepages.c         |   14 ++++++++++++--
 apps/lang/polski.lang     |   14 ++++++++++++++
 apps/lang/english.lang    |   15 ++++++++++++++-
 apps/plugins/viewer.c     |    2 ++
 apps/settings_list.c      |   17 +++++++++--------
 firmware/common/unicode.c |   11 ++++++-----
 8 files changed, 77 insertions(+), 16 deletions(-)

Comment by Przemysław Hołubowski (p.h.) - Thursday, 27 September 2007, 23:45 GMT+2
Patch updated for the rev. 14871.
   cp1250.mk3.patch (8.1 KiB) 
 tools/codepage_tables.c   |   19 +++++++++++++++++++
 tools/codepage_tables.h   |    1 +
 tools/codepages.c         |   14 ++++++++++++--
 apps/lang/polski.lang     |   14 ++++++++++++++
 apps/lang/english.lang    |   15 ++++++++++++++-
 apps/plugins/viewer.c     |    2 ++
 apps/settings_list.c      |   17 +++++++++--------
 firmware/common/unicode.c |   11 ++++++-----
 8 files changed, 77 insertions(+), 16 deletions(-)

Comment by Przemysław Hołubowski (p.h.) - Friday, 28 September 2007, 20:18 GMT+2
Patch updated for the rev. 14871.
   cp1250.mk3.patch (8.1 KiB) 
 tools/codepage_tables.c   |   19 +++++++++++++++++++
 tools/codepage_tables.h   |    1 +
 tools/codepages.c         |   14 ++++++++++++--
 apps/lang/polski.lang     |   14 ++++++++++++++
 apps/lang/english.lang    |   15 ++++++++++++++-
 apps/plugins/viewer.c     |    2 ++
 apps/settings_list.c      |   17 +++++++++--------
 firmware/common/unicode.c |   11 ++++++-----
 8 files changed, 77 insertions(+), 16 deletions(-)

Comment by Przemysław Hołubowski (p.h.) - Friday, 28 September 2007, 20:21 GMT+2
Sorry for multiple comments with the same attachement; it's unintended.

Loading...