Rockbox

In chessbox_pgn.c, the bufleft variable is never updated to reflect the actual size left in the plugin buffer for pseudo dynamic allocation. The original code is:

---------
/* global vars for pl_malloc() */
void *bufptr = NULL;
ssize_t bufleft;

/* simple function to "allocate" memory in pluginbuffer.
* (borrowed from dict.c)
*/
void *pl_malloc(ssize_t size)
{
void *ptr;
ptr = bufptr;

if (bufleft < size)
{
return NULL;
}
else
{
bufptr += size;
return ptr;
}
}

/* init function for pl_malloc() */
void pl_malloc_init(void)
{
bufptr = rb->plugin_get_buffer((size_t *)&bufleft);
}
---------

In pl_malloc(), the bufleft variable should be updated as such:


---------
...
else
{
bufptr += size;


>>>>>>>> bufleft -= size;


return ptr;
}
...
---------