Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7763 - Speed up of video rendering for iPOD Video

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Wednesday, 12 September 2007, 18:05 GMT+2
Last edited by Thom Johansen (preglow) - Friday, 28 September 2007, 13:25 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Speeding up the lcd_yuv_blit()-function for iPOD Video. Measured with "elephants dream" the fps has gone up from 9.1 to 9.9 fps.
   iPOD-lcd-video-v1.patch (7.5 KiB) 
 firmware/target/arm/ipod/video/lcd-video.c |  159 ++++++++++-------------------
 1 file changed, 57 insertions(+), 102 deletions(-)

This task depends upon

Closed by  Thom Johansen (preglow)
Friday, 28 September 2007, 13:25 GMT+2
Reason for closing:  Accepted
Comment by Andree Buschmann (Buschel) - Wednesday, 12 September 2007, 18:16 GMT+2
Changes:
- saved 4 multiplies and 2 substraction
- saved 3 variables
- simplified range-limitation (added 4 shift through this)
Comment by Andree Buschmann (Buschel) - Thursday, 13 September 2007, 11:22 GMT+2
Even more speed-up (now "elephants dream" plays at about 10.4fps, which is +15% compared to trunk).

Changes:
- took over conversion parameters from sansa/gigabeat; these look more reasonable than the former ones
- added some documentation about conversion and constants
- split range-check of RB- and G-components to save 4 shifts (this is faster than only one check with additional shifts)

Bugfix:
- in the former code (also in trunk!) the "-16" in the operation (Y'-16) * RGBYFAC was missing
- in trunk code an allowed value (up to 0x3f) of the green component would always lead to boundary check of all components
   iPOD-lcd-video-v2.patch (8.9 KiB) 
 firmware/target/arm/ipod/video/lcd-video.c |  194 ++++++++++++-----------------
 1 file changed, 82 insertions(+), 112 deletions(-)

Comment by Douglas Valentine (Dwyloc) - Friday, 28 September 2007, 00:59 GMT+2
Your patch would seem to work quite nicely on my 80GB iPod video, now I guess I just have to wait on it being committed to SVN.

Keep up the good work all these little tweaks add up and help to make the iPod ports just that little bit nicer :)

Loading...