Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7777 - Voice for the "Running Time" screen

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Friday, 14 September 2007, 06:45 GMT+2
Last edited by Stephane Doyon (sdoyon) - Wednesday, 07 November 2007, 04:58 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Speaks the "Running Time" screen (under the "System" menu).

Depends on  FS#7774 : Voice callback for gui_synclist.
   running_time.diff (2.2 KiB) 
 trunk/apps/screens.c |   27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Stephane Doyon (sdoyon)
Wednesday, 07 November 2007, 04:58 GMT+2
Reason for closing:  Accepted
Comment by Mario Lang (mlang) - Monday, 17 September 2007, 16:29 GMT+2
Thanks for this accessibility fix, I was just about to do something about it when I saw this patch.
THere is one thing I noticed, the patch does not apply cleanly to latest subversion HEAD because
you are using UNIT_TIME, which is not implemented in subversion HEAD.
I fixed it locally by using UNIT_HOUR, UNIT_MIN and UNIT_SEC and doing basically the same modulo and divide
operations that the code for generating string results already uses.
DId you forget to include a dependency on some other patch that provides UNIT_TIME, or is this just an oversight?
Comment by Mario Lang (mlang) - Monday, 17 September 2007, 16:30 GMT+2
Followup to myself: Of course the patch applies cleanly, but it does not compile because UNIT_TIME is not defined...
Comment by Stephane Doyon (sdoyon) - Monday, 17 September 2007, 16:50 GMT+2
The UNIT_TIME thing is from my id3 viewer patch in P#6323.
I meant to break it out, since I've found use for it here and in my
playing-time patch, but I forgot.

I'll just attach it here.
   talk-time-unit.diff (1.8 KiB) 
 trunk/apps/talk.c |   28 ++++++++++++++++++++++++++++
 trunk/apps/talk.h |    2 ++
 2 files changed, 30 insertions(+)

Comment by Stephane Doyon (sdoyon) - Tuesday, 18 September 2007, 04:37 GMT+2
Sync'ed with recent gui_synclist_do_button change.
The UNIT_TIME stuff is now in P#7798.
   running_time.diff (2.2 KiB) 
 trunk/apps/screens.c |   27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

Comment by Stephane Doyon (sdoyon) - Tuesday, 18 September 2007, 04:40 GMT+2
Nope, that was yesterday's version.. I should go slower. Sorry.
Here it is.
   running_time.diff (2.2 KiB) 
 trunk/apps/screens.c |   24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

Loading...