Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7819 - Unify alarm and time/date screen

Attached to Project: Rockbox
Opened by Alexander Spyridakis (xaviergr) - Sunday, 23 September 2007, 13:57 GMT+1
Last edited by Alexander Spyridakis (xaviergr) - Sunday, 23 September 2007, 15:19 GMT+1
Task Type Patches
Category Applications
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch is a work in progress.

It will remove alarm_menu.c and alarm_menu.h from the source and use the existing code of the time/date screen to set the alarm.

This move has three advantages:
1) Reduces binary size.
2) Makes the alarm screen consistent with the time/date screen.
3) Gives more control on setting the alarm.

This patch will have even more meaning when the RTC alarm drivers are modified to accept months, years etc. as a trigger.
Currently all other entries except hours and minutes will not affect the alarm usage.
   unify_alarm.patch (7.9 KiB) 
 SOURCES               |    1 
 alarm_menu.c          |  165 --------------------------------------------------
 alarm_menu.h          |   24 -------
 menus/settings_menu.c |   46 ++++++++++++-
 4 files changed, 42 insertions(+), 194 deletions(-)

This task depends upon

Comment by Robert Kukla (roolku) - Sunday, 23 September 2007, 17:28 GMT+1
I quite like the ease and effectiveness of the original alarm setting screen. How many more key presses do you need to set the alarm with the new method? Why on earth would you want to use month or even years as an alarm trigger on a DAP?
Comment by Alexander Spyridakis (xaviergr) - Sunday, 23 September 2007, 19:25 GMT+1
roolku: on the contrary, fewer key presses, more control and you don't have to think about the date if you don't want to set it.
There is nothing effective to have to pass 5 hours on an interval of 5 minutes to set your preferred time. The time/date screen allows you to set the time easier, faster and more accurately.

Loading...