Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7831 - FLAC files with "unknown" total samplecount are rejected

Attached to Project: Rockbox
Opened by Dave Chapman (linuxstb) - Tuesday, 25 September 2007, 10:48 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Friday, 02 July 2010, 20:42 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The current Rockbox FLAC codec rejects files (in apps/metadata/flac.c) where the "samplecount" field in the header is 0. However, the FLAC specification says that this is a valid value and should be interpreted as "unknown".

The only encoder I've seen which generates such files is ffmpeg.
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Friday, 02 July 2010, 20:42 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r27244.
Comment by Joshua Hulst (jhulst) - Friday, 12 October 2007, 05:44 GMT+2
When totalsamples (samplerate) is 0, length and bitrate are set to 0 because their calculation depends on samplerate, else behave as before. Setting the length to 0 removes the possibility for seeking during playback, but the file is still loadable and playable.

This is my first patch, all comments and suggestions are appreciated.

Josh
   samplecount.diff (1.2 KiB) 
 rockbox/apps/metadata/flac.c |   15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Comment by Rosso Maltese (asettico) - Saturday, 01 March 2008, 12:41 GMT+2
Just some slight modifications to apply to current build (16460) without fuzz factor.
   samplecount-v2.patch (1.2 KiB) 
 rockbox/apps/metadata/flac.c |   15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Comment by Rosso Maltese (asettico) - Tuesday, 03 March 2009, 14:24 GMT+2
Resync (just offset lines)
   codecs-7831flac-samplecount-v3.1.patch (1.2 KiB) 
 rockbox/apps/metadata/flac.c |   15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Loading...