Rockbox

Tasklist

FS#7856 - WPS image not clearing fully

Attached to Project: Rockbox
Opened by rbx-Multiplex (rbx-multiplex) - Friday, 28 September 2007, 09:23 GMT
Last edited by Nicolas Pennequin (nicolas_p) - Sunday, 18 November 2007, 15:33 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

There is an issue with images not clearing properly, it is easily demonstrated with the enclosed WPS (H300 but I have no reason to believe that it is device specific).

When clearing the lock icon(M) it leaves the right hand column of pixels behind.

Sometimes it clears later when other bits of the screen update.
It can allways be cleared by locking both the main and remote and clearing the main first.

It can be worked arround by modifying a different image (I added a transparent column to the R, making it bigger) - but this does not have to be displayed to 'fix' the problem.
Occurs on a real unit and Rasher's simulator.
I'm not bothered about the issue but as it's such an easy re-create I thought it might help to fix it.
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Sunday, 18 November 2007, 15:33 GMT
Reason for closing:  Fixed
Comment by rbx-Multiplex (rbx-multiplex) - Friday, 28 September 2007, 09:24 GMT
Where did the WPS file go...
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 18 November 2007, 14:41 GMT
That's an interesting problem... The reason for it is that images are cleared when the conditional they are in changes value. However from the structure of your WPS, all images belong to %?mr conditionals (a picture an only belong to one conditional), which means toggling the main hold switch will never clear the hold picture.
The line that remains is the same issue of not clearing the picture because it's not found to be in the conditional that changes value.
This may sound like a strange limitation, but it is a hard one to remove.
I suggest using three distinct pictures (i, j and k), all including the lock, with the same dimensions and no transparency. The following code works:

%?mh<%xdi>
%?mr<%xdj>
%?mr<%?mh<%xdk>>

Picture i is cleared when main hold is toggled. j is cleared when remote hold is toggled. k is cleared when main hold is toggled (not remote hold), but the order of display ensures that it works properly.
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 18 November 2007, 15:21 GMT
Well after a bit of thought, I realized removing that limitation I was talking about wasn't has hard as I thought, so I have a fix almost ready to commit. It makes your WPS work perfectly without any changes.

Loading...