Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7858 - tiny improvement on tagtree.c

Attached to Project: Rockbox
Opened by Xinlu Huang (polygonal) - Friday, 28 September 2007, 23:17 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 17 November 2010, 06:08 GMT+2
Task Type Patches
Category Database
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently tagtree.c parses everything from tagnavi file(s), which is unnecessary because once a root menu is found, nothing more is needed since only the first root menu is used and anything used by that should be defined before the root_menu statement.

So I basically tell the parser to stop as soon as a valid root_menu is set. Obviously this fix is not a big deal, but the parser annoys me because it produces a lots of useless logf's when I tried to debug my own custom_tagnavi file that sets a different root menu.

I also removed a obsolete comment (the syntax in that comment is out of date).
   tagtree.patch (1.4 KiB) 
 apps/tagtree.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 17 November 2010, 06:08 GMT+2
Reason for closing:  Not a Bug
Additional comments about closing:  see the last comment
Comment by Xinlu Huang (polygonal) - Saturday, 29 September 2007, 01:37 GMT+2
oops, sorry about the crlf ending... TortoiseSVN changed it without me knowing.
   tagtree.patch (1.4 KiB) 
 apps/tagtree.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

Comment by Peter D'Hoye (petur) - Monday, 01 October 2007, 21:46 GMT+2
tortoiseSVN works native, so all files it works with are CR-LF on windows
Comment by Rosso Maltese (asettico) - Tuesday, 03 March 2009, 14:46 GMT+2
Resync (just offset lines)
   db-7858tagtree-v2.0.patch (1.4 KiB) 
 apps/tagtree.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

Comment by sideral (sideral) - Thursday, 04 November 2010, 20:16 GMT+2
The reasoning does not appear to be valid: A root_menu can use other menus defined after itself. For example, a root_menu defined in a tagnavi_custom.config can refer to menus defined in tagnavi.config after tagnavi_custom.config has been included.

Loading...