Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7873 - New keymap for e200's text editor

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Sunday, 30 September 2007, 20:20 GMT+1
Last edited by Dave Chapman (linuxstb) - Sunday, 30 September 2007, 20:21 GMT+1
Task Type Patches
Category User Interface
Status Unconfirmed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This (my second) patch changes the keymap of the e200 to a more natural and easier to use one.

Changes:
Editor plugin:
Remove removing a line with context-menu-button
swap the function of power button and left button

Keyboard typing screen
up/down/left/right for browsing in the characters
scrollwheel to move the cursor
rec+up to finish editting the line
rec+down = backspace

I find this much easier to use

Suggestions are welcome, since I can imagine, that it can be optimized even more
   editor_keymap.diff (3.8 KiB) 
 keymaps/keymap-e200.c |   23 ++++++++++++-----------
 plugins/text_editor.c |   12 +++---------
 2 files changed, 15 insertions(+), 20 deletions(-)

This task depends upon

Comment by Thomas Martitz (kugel.) - Monday, 01 October 2007, 15:39 GMT+1
Small update, should improve the rec+up/down behavior.
   editor_keymap_v2.diff (3.8 KiB) 
 keymaps/keymap-e200.c |   23 ++++++++++++-----------
 plugins/text_editor.c |   12 +++---------
 2 files changed, 15 insertions(+), 20 deletions(-)

Comment by Thomas Martitz (kugel.) - Sunday, 28 October 2007, 01:08 GMT+1
Updated the patch, so that the swap of power and left button doesn't hit other targets.

Also, got rid of the rec+up/rec+down: Backspace is REC now and Accept/Done is Hold Select.
   editor_keymap_v3.diff (3.9 KiB) 
 keymaps/keymap-e200.c |   24 ++++++++++++------------
 plugins/text_editor.c |   20 +++++++++++---------
 2 files changed, 23 insertions(+), 21 deletions(-)

Comment by Thomas Martitz (kugel.) - Sunday, 04 November 2007, 00:18 GMT+1
Little bug fix.
   editor_keymap_v3b.diff (3.9 KiB) 
 keymaps/keymap-e200.c |   24 ++++++++++++------------
 plugins/text_editor.c |   20 +++++++++++---------
 2 files changed, 23 insertions(+), 21 deletions(-)

Comment by Thomas Martitz (kugel.) - Monday, 19 November 2007, 22:47 GMT+1
New version:
* The feature to delete on line via hotkey returned, it's hold select as in the SVN
* In the SVN, the "Do what" menu moved to button_down, I changed it to be button_power. Note: I needed to hack a but, since there is no standard action for the power button. I created an action ACTION_STD_POWER_BUTTON_PRESS, which has no use, except making the button usable in the text editor.
* I changed the button_left function to only cancel editing (aka ignore changes and exit), but it shows a splash when there were unsaved changes
* I mapped the "line options" menu to button_down.

Note2: I planned to map the delete line via hotkey feature to the rec_button, but I didn't implement, since it conflicts with another patch I use. However, if you liked it I'd implement it.

Just a question: I know this patch isn't done in a proper way, which is mainly a result of the text_editor using standard context. But is there any chance for a commit, even if only the keyboard screen changes would get committed?

   editor_keymap_v4.diff (4 KiB) 
 action.h              |    1 +
 keymaps/keymap-e200.c |   25 +++++++++++++------------
 plugins/text_editor.c |    9 +++++++++
 3 files changed, 23 insertions(+), 12 deletions(-)

Comment by Mike Kasberg (digerati1338) - Thursday, 03 January 2008, 19:01 GMT+1
I would also like to know if there's any chance of this patch getting committed. It really does make more sense this way. Having to use left/right buttons and then the scrollwheel to select characters doesn't feel right.
Comment by Thomas Martitz (kugel.) - Saturday, 05 January 2008, 23:03 GMT+1
Well, v4 isn't working. The reason I didn't notice is that I'm using the real v4 (attached as v5), the v4 I uploaded was the wrong file. Weird but here you go.
   editor_keymap_v5.diff (4.3 KiB) 
 action.h              |    1 +
 keymaps/keymap-e200.c |   26 +++++++++++++-------------
 plugins/text_editor.c |    7 +++++++
 3 files changed, 21 insertions(+), 13 deletions(-)

Comment by David Maliniak (major_works) - Thursday, 10 January 2008, 22:27 GMT+1
Needs syncing with commit of FS #8341.
Comment by Thomas Martitz (kugel.) - Thursday, 10 January 2008, 22:39 GMT+1
Just change every BUTTON_SCROLL_UP to BUTTON_SCROLL_BACK and BUTTON_SCROLL_DOWN to BUTTON_SCROLL_FWD.

Loading...