Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7901 - Fix gradient for scrolling strings when more than one line is selected

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Sunday, 07 October 2007, 21:44 GMT+2
Last edited by Nicolas Pennequin (nicolas_p) - Monday, 19 November 2007, 19:15 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Fix gradient for scrolling strings when more than one line is selected (running time, ID3 info, cuesheet viewer...)
I think that this patch is more suitable for svn-r14884 fix...
   fix-gradient.patch (3.7 KiB) 
 apps/gui/list.c              |   10 +++++++---
 firmware/drivers/lcd-16bit.c |   28 ++++++++++++++++++----------
 2 files changed, 25 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Monday, 19 November 2007, 19:15 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Akio Idehara (idak) - Sunday, 07 October 2007, 23:30 GMT+2
Some code changes...
   fix-gradient-2.patch (4 KiB) 
 apps/gui/list.c              |   10 +++++++---
 firmware/drivers/lcd-16bit.c |   34 ++++++++++++++++++++++++----------
 2 files changed, 31 insertions(+), 13 deletions(-)

Comment by Akio Idehara (idak) - Tuesday, 09 October 2007, 17:09 GMT+2
Now I separate one line gradient code and multi line gradient code...
   fix-gradient-3.patch (4.4 KiB) 
 apps/gui/list.c              |   14 +++++++++--
 firmware/drivers/lcd-16bit.c |   52 +++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 61 insertions(+), 5 deletions(-)

Comment by Akio Idehara (idak) - Wednesday, 10 October 2007, 17:41 GMT+2
Clean up some code.
   fix-gradient-4.patch (4.5 KiB) 
 apps/gui/list.c              |   12 +++++++++---
 firmware/export/lcd.h        |    8 ++++++++
 firmware/drivers/lcd-16bit.c |   41 +++++++++++++++++++++++++++++++++++++++--
 3 files changed, 56 insertions(+), 5 deletions(-)

Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 10 October 2007, 19:17 GMT+2
Thanks a lot for this. I'm sorry I still haven't looked at it, but I will ASAP :)
Comment by Akio Idehara (idak) - Tuesday, 16 October 2007, 17:14 GMT+2
sync
   fix-gradient-5.patch (4.5 KiB) 
 apps/gui/list.c              |   12 +++++++++---
 firmware/export/lcd.h        |    8 ++++++++
 firmware/drivers/lcd-16bit.c |   41 +++++++++++++++++++++++++++++++++++++++--
 3 files changed, 56 insertions(+), 5 deletions(-)

Comment by Pascal Briehl (ColdSphinX) - Friday, 19 October 2007, 06:15 GMT+2
works fantastic, thanks
vote for it

Loading...