Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7916 - Adapt graphical EQ to smaller screens

Attached to Project: Rockbox
Opened by Mark Arigo (lowlight) - Tuesday, 09 October 2007, 20:25 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 09 November 2008, 11:28 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The current graphical eq screen does not fit all five bands onto the smaller screen of the Sansa c200 (132x80). This patch allows the screen to scroll in order to access all the bands. Also, rather than keep the special case for the remote screen, it is now displayed in a similar manner.

I tested this on the c200 (device & sim) and on the h120 sim in order to test the remote display. On most devices, it should not look any different because all five bands fit on the display.

More testing welcome, as are comments.
   eq_screen.patch (15 KiB) 
 apps/lang/english.lang |    8 -
 apps/menus/eq_menu.c   |  315 +++++++++++++++++++++++--------------------------
 2 files changed, 153 insertions(+), 170 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 09 November 2008, 11:28 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  easier than I thought to fix the draweing glitches... commited
Comment by Dan Everton (safetydan) - Tuesday, 09 October 2007, 22:43 GMT+2
Just quickly reviewed the patch. Looks good. I'd say commit it.
Comment by Dan Everton (safetydan) - Wednesday, 10 October 2007, 11:39 GMT+2
Actually now that I've tested it on my H120 I've found that the controls don't work on the LCD remote. You can navigate between the bands and the settings but not change them.
Comment by Mark Arigo (lowlight) - Wednesday, 10 October 2007, 15:02 GMT+2
Could you change them before using the remote? I don't think I touched the any button code.
Comment by Dan Everton (safetydan) - Wednesday, 10 October 2007, 22:36 GMT+2
Nope, can't change the settings from the remote in a normal build. So your patch hasn't changed anything there. Looking closer it seems there's no rc key context for the eq, but that can be fixed later.
Comment by Dominik Riebeling (bluebrother) - Saturday, 20 October 2007, 21:42 GMT+2
I had a quick look at this. There are some display issues (tried on ipod mini sim):
- going from PK3 to HS gives a really strange effect with the display kinda jumping around
- the text is cropped due to the limited size of the display (the "0.0dB" shows only "0.0c", the Q value only shows the last digit)
Comment by Dave Chapman (linuxstb) - Saturday, 20 October 2007, 22:04 GMT+2
Sync with SVN r15227
   eq_screen-r15227.diff (15 KiB) 
 apps/lang/english.lang |    8 -
 apps/menus/eq_menu.c   |  315 +++++++++++++++++++++++--------------------------
 2 files changed, 153 insertions(+), 170 deletions(-)

Comment by William (lee321987) - Thursday, 03 July 2008, 08:09 GMT+2
I'm getting a hunk failure. Any chance for a re-sync? Thanks in advance.
Comment by Jonathan Gordon (jdgordon) - Sunday, 09 November 2008, 11:03 GMT+2
sync... the screen issues Dominik mentioned are still there and only seem to appear on the mini sim... planning to have a bit more of a play with this to fix  FS#9517 
   eq_screen.diff (15.1 KiB) 
 apps/lang/english.lang |    8 -
 apps/menus/eq_menu.c   |  315 +++++++++++++++++++++++--------------------------
 2 files changed, 153 insertions(+), 170 deletions(-)

Loading...