This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#7962 - USB device code for sansa
Attached to Project:
Rockbox
Opened by Björn Stenberg (zagor) - Monday, 15 October 2007, 13:49 GMT+2
Last edited by Björn Stenberg (zagor) - Friday, 23 November 2007, 22:48 GMT+2
Opened by Björn Stenberg (zagor) - Monday, 15 October 2007, 13:49 GMT+2
Last edited by Björn Stenberg (zagor) - Friday, 23 November 2007, 22:48 GMT+2
|
DetailsCurrent state of my USB implementation. Configuration/enumeration/setup works, but the bulk input (OUT) endpoint doesn't trigger any interrupt so the usb-storage commands are not received.
sansausb.patch
(176.1 KiB)
apps/settings.c | 16 apps/menus/settings_menu.c | 92 -- apps/settings_list.c | 12 apps/tagcache.c | 2 apps/main.c | 9 apps/tagtree.c | 1 firmware/export/usb_drv.h | 32 firmware/export/config-c200.h | 6 firmware/export/usbstack.h | 63 - firmware/export/usb_ch9.h | 32 firmware/export/arcotg_udc.h | 318 ------- firmware/export/usb_core.h | 50 + firmware/export/pp5020.h | 2 firmware/usb_storage.c | 103 ++ firmware/usb_storage.h | 27 firmware/usbstack/host.h | 31 firmware/usbstack/device.h | 47 - firmware/usbstack/utils.h | 25 firmware/usbstack/core/utils.c | 176 ---- firmware/usbstack/core/config.c | 82 - firmware/usbstack/core/epsetup.c | 175 ---- firmware/usbstack/core/core.c | 402 --------- firmware/usbstack/controller.h | 88 -- firmware/usbstack/drivers/device/usb_storage.h | 33 firmware/usbstack/drivers/device/usb_serial.c | 358 -------- firmware/usbstack/drivers/device/usb_serial.h | 33 firmware/usbstack/drivers/device/usb_storage.c | 387 --------- firmware/usbstack/core.h | 64 - firmware/usb_core.c | 363 ++++++++ firmware/SOURCES | 27 firmware/target/arm/usb-fw-pp502x.c | 111 -- firmware/target/arm/usb-drv-pp502x.c | 527 ++++++++++++ firmware/target/arm/system-pp502x.c | 15 firmware/FILES | 3 firmware/drivers/usb/arcotg_dcd.h | 179 ---- firmware/drivers/usb/arcotg_dcd.c | 1050 ------------------------- firmware/drivers/usb/arcotg_udc.c | 136 --- 37 files changed, 1176 insertions(+), 3901 deletions(-) |
This task depends upon
Closed by Björn Stenberg (zagor)
Friday, 23 November 2007, 22:48 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed to SVN
Friday, 23 November 2007, 22:48 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed to SVN
Something that looks suspicious is the endpoint number assignment, you use endpoint number 1 for both the bulk in and the bulk out endpoints, with the two endpoints only distinguished by the direction bit. The USB2.0 spec is a bit vague on whether this is supported, but I can't remember ever seeing something like this being used in other USB devices. Better would be endpoint addresses 0x01 for OUT and 0x82 for IN.
Also nothing seem to happen yet on reception of a USB_REQ_SET_CONFIGURATION request. I think this is a good place to enable/configure the endpoints.
Example from Linux driver (fsl_ep_enable / dr_ep_setup):
http://lxr.linux.no/source/drivers/usb/gadget/fsl_usb2_udc.c#L448
http://lxr.linux.no/source/drivers/usb/gadget/fsl_usb2_udc.c#L318
SET_CONFIGURATION is not looked at (only ACKed immediately) because the device only has one configuration, which is already active. If we add more configurations, SET_CONFIGURATION will do more.
The problem I'm fighting currently is that my CSWs (command status wrappers, sort of ACKs for usb-storage) don't come out on the bus the way I send them to the driver. The first CSW is all zeroes, and subsequent ones have a too old cbw tag! See http://bjorn.haxx.se/usbmon.txt.
It's almost as if old CSWs are being buffered in the driver and sent later. Yet the driver only uses a single transmit buffer, which inbetween the failed CSWs is also used for sucessfully sending the data-in portions (the INQUIRY struct). So that's a bit of a mystery at this point.
The purpose of my effort is to try and implement USB with simple straight-forward code that is easy to understand and easy to debug.