Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7966 - Incorrect menu captions in playback control menu (always 'Yes')

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Monday, 15 October 2007, 21:41 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 20 October 2007, 23:56 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Setup:
* Sansa e260 with r15122

How to reproduce:
* Start a game plugin that has an 'Audio Playback' menu, e.g. sokoban or solitaire.
* Enter the Audio Playback menu and select either 'Change Volume', 'Enable/disable shuffle' or 'Change repeat mode': menu caption of sub-menu is always 'Yes'.

Analysis:
* the last argument in all function api->option_screen callbacks (title) is NULL.
* 'Yes' is the text for language id 0.
This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 20 October 2007, 23:56 GMT+2
Reason for closing:  Accepted
Comment by Bertrik Sikken (bertrik) - Monday, 15 October 2007, 22:32 GMT+2
Here's a simple patch that fixes it. It doesn't do internationalisation though, I get compile errors when I try to #include lang.h
   playbackcontrol_menu.diff (1.2 KiB) 
 apps/plugins/lib/playback_control.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment by Bertrik Sikken (bertrik) - Wednesday, 17 October 2007, 19:30 GMT+2
It turns out that plugins don't support internationalisation (yet), so I think using literal strings is a valid way to solve the problem.

Loading...