Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7977 - Bootloader logo

Attached to Project: Rockbox
Opened by Barry Wardell (barrywardell) - Wednesday, 17 October 2007, 01:36 GMT+2
Last edited by Barry Wardell (barrywardell) - Monday, 05 May 2008, 14:05 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently the bootloaders show nothing on screen unless there is an error or a button is pressed. This patch makes the bootloader show the Rockbox logo and bootloader version, similar to what the main Rockbox binary does while booting.

Tested on Sansa e280 and H10 20GB. I've adjusted the code for all other targets too, but haven't tested it.
   boot-logo.patch (7.2 KiB) 
 bootloader/main-pp.c     |   14 +++++++++-----
 bootloader/gigabeat.c    |    5 ++++-
 bootloader/main.c        |    1 +
 bootloader/iaudio_x5.c   |    2 ++
 bootloader/common.c      |   19 +++++++++++++++++++
 bootloader/iriver_h300.c |    1 +
 bootloader/ipod.c        |    6 +++++-
 bootloader/Makefile      |   46 +++++++++++++++++++++++++++++++++++++++++++---
 8 files changed, 84 insertions(+), 10 deletions(-)

This task depends upon

Closed by  Barry Wardell (barrywardell)
Monday, 05 May 2008, 14:05 GMT+2
Reason for closing:  Accepted
Comment by Barry Wardell (barrywardell) - Wednesday, 30 April 2008, 18:06 GMT+2
Synced to svn. I've also made some changes in this version. To enable a bootloader logo for a target, it is now necessary to put #define HAVE_BOOTLOADER_LOGO in the relevant config-*.h file. This patch does so for e200 only for now as that's all I've tested on.
   bootlogo2.patch (6.7 KiB) 
 bootloader/main-pp.c          |   25 ++++++++++++++++------
 bootloader/common.c           |   22 ++++++++++++++++++++
 bootloader/Makefile           |   46 +++++++++++++++++++++++++++++++++++++++---
 bootloader/common.h           |    6 ++++-
 firmware/export/config-e200.h |    3 ++
 5 files changed, 91 insertions(+), 11 deletions(-)

Comment by Barry Wardell (barrywardell) - Wednesday, 30 April 2008, 18:09 GMT+2
Another quick update. This time, the bitmaps are just read directly from the apps build dir. I'm not sure if this is the best way to do things, but it works for me.
   bootlogo3.patch (6.7 KiB) 
 bootloader/main-pp.c          |   25 ++++++++++++++++------
 bootloader/common.c           |   22 ++++++++++++++++++++
 bootloader/Makefile           |   46 +++++++++++++++++++++++++++++++++++++++---
 bootloader/common.h           |    6 ++++-
 firmware/export/config-e200.h |    3 ++
 5 files changed, 91 insertions(+), 11 deletions(-)

Comment by Barry Wardell (barrywardell) - Thursday, 01 May 2008, 13:57 GMT+2
Updated version:
* Only builds the bitmaps that are actually used by the bootloader (i.e. rockboxlogo)
* Checks the size of the produced mi4. If it's too big to fit into IRAM, delete it and produce a warning.
   bootlogo4.patch (10.9 KiB) 
 bootloader/main-pp.c               |   25 +++++++++++-----
 bootloader/common.c                |   22 ++++++++++++++
 bootloader/Makefile                |   56 ++++++++++++++++++++++++++++++++++---
 bootloader/common.h                |    6 +++
 tools/configure                    |    3 +
 tools/romsizetest.pl               |    9 +++--
 apps/Makefile                      |    2 -
 apps/bitmaps/remote_native/SOURCES |    4 ++
 apps/bitmaps/native/SOURCES        |    4 ++
 firmware/export/config-e200.h      |    3 +
 10 files changed, 117 insertions(+), 17 deletions(-)

Comment by Barry Wardell (barrywardell) - Thursday, 01 May 2008, 18:27 GMT+2
Another update. This time it uses the linker to tell if it's too big to fit in IRAM.
   bootlogo6.patch (8.7 KiB) 
 bootloader/main-pp.c                 |   25 +++++++++++++------
 bootloader/common.c                  |   22 ++++++++++++++++
 bootloader/Makefile                  |   46 ++++++++++++++++++++++++++++++++---
 bootloader/common.h                  |    6 +++-
 apps/bitmaps/remote_native/SOURCES   |    4 +++
 apps/bitmaps/native/SOURCES          |    4 +++
 firmware/export/config-e200.h        |    3 ++
 firmware/target/arm/sandisk/boot.lds |   16 +++++++++---
 8 files changed, 111 insertions(+), 15 deletions(-)

Comment by Barry Wardell (barrywardell) - Monday, 05 May 2008, 14:05 GMT+2
Final version committed to svn. I removed the need for HAVE_BOOTLOADER_LOGO, but otherwise this is unchanged.
   bootlogo7.patch (5.7 KiB) 
 bootloader/main-pp.c               |   20 +++++++++++-----
 bootloader/SOURCES                 |    1 
 bootloader/Makefile                |   46 ++++++++++++++++++++++++++++++++++---
 apps/bitmaps/remote_native/SOURCES |    4 +++
 apps/bitmaps/native/SOURCES        |    4 +++
 5 files changed, 66 insertions(+), 9 deletions(-)

Loading...