Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7989 - WMA Seeking

Attached to Project: Rockbox
Opened by MichaelGiacomelli (saratoga) - Thursday, 18 October 2007, 22:58 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Thursday, 22 November 2007, 07:26 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

At preglow's request, here are the two patches that have been floating around for seeking in WMA.

The first works, but is slow and inaccurate. Theres a good chance you'll end up in the next song if you seek too far.

The second doesn't work at all for some reason, but should be much faster when fixed. It works like the first, but does a binary search for the correct ASF packet and attempts to restart playback at the new one. I spent ~15 minutes debugging it and ran out of time. If someone else wants to take a look at it, I'm sure its not that hard to fix. Actually seeking in general with WMA is quite simple, I just don't have time to debug it.

Otherwise I'll finish it as soon as my workload eases up.
   wmaseeking.patch (7.2 KiB) 
 wma.c |  205 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 202 insertions(+), 3 deletions(-)

   seeking_2.patch (5.9 KiB) 
 unknown |  167 ++--------------------------------------------------------------
 1 file changed, 6 insertions(+), 161 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Thursday, 22 November 2007, 07:26 GMT+2
Reason for closing:  Accepted
Comment by MichaelGiacomelli (saratoga) - Thursday, 22 November 2007, 04:14 GMT+2
Fixed most of the problems in the V2 patch. Seems stable in the Sim on my files, and seeks efficiently. Will need more testing before I add it to SVN.
   wma_seeking_3.patch (7.6 KiB) 
 apps/codecs/wma.c |  181 ++++++++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 169 insertions(+), 12 deletions(-)

Comment by JerryLange (psycho_maniac) - Thursday, 22 November 2007, 05:20 GMT+2
this patch is does not work on my player. i have the ipod video 5.5g. also for the progress bar shows the bar to 100%.
Comment by JerryLange (psycho_maniac) - Thursday, 22 November 2007, 05:33 GMT+2
this is easier to explain it
this is what its supposed to look:
http://xs221.xs.to/xs221/07474/dump071121-222454.png
this is what id does look like:
http://xs221.xs.to/xs221/07474/dump071121-222526.png

Loading...