Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8006 - Beep when charger is removed or connected

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Sunday, 21 October 2007, 04:22 GMT+1
Task Type Patches
Category Battery/Charging
Status New
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This very small patch simply plays a beep when a charger is removed or plugged in.
I know  FS#7910  voiced this but that was a bit annoying.

The charger stuff will be removed from p7910. I could have added this to it but it isn't really that related.
   beep-charger.diff (0.8 KiB)
This task depends upon

Comment by Daniel Dalton (ddalton) - Sunday, 21 October 2007, 04:49 GMT+1
Beep only if talk_menu is enabled.
   beep-charger.patch (0.9 KiB)
Comment by Daniel Dalton (ddalton) - Monday, 22 October 2007, 00:20 GMT+1
Now depend on a beep_notification setting.
Requires  FS#8007 .
   charger-beep.diff (0.9 KiB)
Comment by Daniel Dalton (ddalton) - Monday, 22 October 2007, 11:06 GMT+1
Will apply with out
 FS#8007 
But won't compile. This is because global_settings.beep_notification doesn't exist in rockbox.
 FS#8007  adds an option called "Beep notifications" and uses global_settings.beep_notification to hold its setting...
Just thought I would explain it.

Anyway this update just makes the beep more noticeable (I think :-))
Enjoy...
   charger-beep-updated.patch (0.9 KiB)
Comment by Daniel Dalton (ddalton) - Wednesday, 18 June 2008, 12:34 GMT+1
I think it is better to just use
talk_menu since beep_setting was closed and really was just a waste of space. No functional change,
Just no more dependencies and rely on talk_menu.
Is anyone interested in committing?
It really is a very small change.

Thanks.
   charger-beep.diff (0.9 KiB)
Comment by Stephane Doyon (sdoyon) - Friday, 20 June 2008, 02:39 GMT+1
I'll try it out and probably commit.

Loading...