Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8046 - H10 Radio

Attached to Project: Rockbox
Opened by Barry Wardell (barrywardell) - Tuesday, 30 October 2007, 02:47 GMT+2
Last edited by Barry Wardell (barrywardell) - Sunday, 11 November 2007, 17:03 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type iriver H10
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is my first attempt at getting the FM radio working on the H10. I did this quite a while ago. Quite a few things have changed in svn since then, so I've done a quick sync and hopefully not missed anything.

Unfortunately, it doesn't seem to work at all right now and never did. The FM radio debug screen seems to indicate that the I2C communication with the device is somehow not working (at least some of those data bytes should be non-zero).
   h10-radio.patch (3.4 KiB) 
 firmware/export/config-h10.h               |    6 +++---
 firmware/export/config-h10_5gb.h           |    6 +++---
 firmware/target/arm/audio-pp.c             |    1 +
 firmware/target/arm/iriver/h10/power-h10.c |    2 --
 firmware/drivers/fmradio_i2c.c             |   20 +++++++++++++++++++-
 5 files changed, 26 insertions(+), 9 deletions(-)

This task depends upon

Closed by  Barry Wardell (barrywardell)
Sunday, 11 November 2007, 17:03 GMT+2
Reason for closing:  Accepted
Comment by Przemysław Hołubowski (p.h.) - Friday, 09 November 2007, 22:01 GMT+2
I've changed i2c from hardware PP5020 i2c to software as i2c communication with tuner chip is done via software. Look at here: http://www.rockbox.org/twiki/bin/view/Main/PortPinAssignments#H10_GPIO
(fmradio_i2c.c)
   h10-radio_new_i2c.patch (4.3 KiB) 
 firmware/drivers/fmradio_i2c.c             |   23 +++++++++++++++++++++++
 firmware/export/config-h10.h               |    6 +++---
 firmware/export/config-h10_5gb.h           |    6 +++---
 firmware/target/arm/audio-pp.c             |    2 ++
 firmware/target/arm/iriver/h10/power-h10.c |   13 ++++++++++---
 5 files changed, 41 insertions(+), 9 deletions(-)

Comment by Barry Wardell (barrywardell) - Friday, 09 November 2007, 22:24 GMT+2
There was a problem with the confusing #ifdef's in fmradio_i2c.c in the last patch. Hopefully this one will fix that up.
   h10-radio_new_i2c2.patch (6.4 KiB) 
 rbutil/e200rpatcher/Makefile               |    8 +++---
 firmware/export/config-h10.h               |    6 ++--
 firmware/export/config-h10_5gb.h           |    6 ++--
 firmware/target/arm/audio-pp.c             |    2 +
 firmware/target/arm/iriver/h10/power-h10.c |   13 ++++++++--
 firmware/drivers/fmradio_i2c.c             |   36 +++++++++++++++--------------
 6 files changed, 41 insertions(+), 30 deletions(-)

Comment by Jens Arnold (amiconn) - Saturday, 10 November 2007, 01:04 GMT+2
Same patch, but using the atomic GPIO bit manipulation macros (a feature of the PP502x), and without the unrelated Sansa e200rpatcher change.
   h10-radio_new_i2c3.patch (5.2 KiB) 
 firmware/export/config-h10.h               |    6 ++--
 firmware/export/config-h10_5gb.h           |    6 ++--
 firmware/target/arm/audio-pp.c             |    2 +
 firmware/target/arm/iriver/h10/power-h10.c |   13 ++++++++--
 firmware/drivers/fmradio_i2c.c             |   36 +++++++++++++++--------------
 5 files changed, 37 insertions(+), 26 deletions(-)

Comment by Jens Arnold (amiconn) - Saturday, 10 November 2007, 02:16 GMT+2
One possible reason why it hangs could be that iriver forgot the SCL pullup (a familiar mistake, see the comment in the H1x0 part of fmradio-i2c.c) and we need to "prod-and-check" the SCL line, otherwise the clock stretch would be infinite.

Apart from that, this patch is a hack as it breaks FM radio on Ondio. Hijacking other arch's code isn't nice...
Comment by Przemysław Hołubowski (p.h.) - Saturday, 10 November 2007, 12:15 GMT+2
It seems SCL pullup is not the case as the patch using H1x0 i2c code does not work on H10 (booting still fails).
   h10-radio_new_i2c4.patch (8.8 KiB) 
 firmware/drivers/fmradio_i2c.c             |  216 ++++++++++++++++++++++++++++-
 firmware/export/config-h10.h               |    6 
 firmware/export/config-h10_5gb.h           |    6 
 firmware/target/arm/audio-pp.c             |    3 
 firmware/target/arm/iriver/h10/power-h10.c |   13 +
 5 files changed, 229 insertions(+), 15 deletions(-)

Comment by Barry Wardell (barrywardell) - Saturday, 10 November 2007, 13:22 GMT+2
I just tried this on my own H10. It looks like the wait for SCL is indeed causing problems. I #if 0'd out the two while loops and Rockbox now starts up fine. The debug screen even manages to report values for the regs. They read as:

Read: D0 78 02 00 BC
Write: 00 00 00 00 00

I'm not sure if these are right. I think it documents them in the datasheet, but haven't had a chance to take a proper look.

No luck with sound yet, too. We probably need to look a bit closer at the code in audio-pp.c for that. We'll also probably need to figure out what to do about the wait for SCL.
   h10-radio_new_i2c5.patch (8.8 KiB) 
 firmware/export/config-h10.h               |    6 
 firmware/export/config-h10_5gb.h           |    6 
 firmware/target/arm/audio-pp.c             |    3 
 firmware/target/arm/iriver/h10/power-h10.c |   13 +
 firmware/drivers/fmradio_i2c.c             |  218 ++++++++++++++++++++++++++++-
 5 files changed, 231 insertions(+), 15 deletions(-)

Comment by Jens Arnold (amiconn) - Saturday, 10 November 2007, 23:57 GMT+2
New patch, implementing the H1x0 way of handling clock stretching on H10, correcting 2 goofs of my old patch as well. Also adapted to the fmradio i2c drivers residing in target tree.

The driver seems to talk to the chip just fine, tuning finds a signal where expected in my area, but there's no sound yet. Also, the radio controls are messed up so the only thing that works is tuning....
   h10-radio_new_i2c6.patch (9.1 KiB) 
 firmware/export/config-h10.h                     |    6 
 firmware/export/config-h10_5gb.h                 |    6 
 firmware/SOURCES                                 |    2 
 firmware/target/arm/audio-pp.c                   |    1 
 firmware/target/arm/iriver/h10/power-h10.c       |   13 +
 firmware/target/arm/iriver/h10/fmradio_i2c-h10.c |  206 +++++++++++++++++++++++
 6 files changed, 225 insertions(+), 9 deletions(-)

Comment by Jens Arnold (amiconn) - Sunday, 11 November 2007, 00:45 GMT+2
New patch, including a working keymap.
   h10-radio_7.patch (11.4 KiB) 
 apps/recorder/radio.c                            |    4 
 apps/keymaps/keymap-h10.c                        |   23 ++
 firmware/export/config-h10.h                     |    6 
 firmware/export/config-h10_5gb.h                 |    6 
 firmware/SOURCES                                 |    2 
 firmware/target/arm/audio-pp.c                   |    1 
 firmware/target/arm/iriver/h10/power-h10.c       |   13 +
 firmware/target/arm/iriver/h10/fmradio_i2c-h10.c |  206 +++++++++++++++++++++++
 8 files changed, 251 insertions(+), 10 deletions(-)

Comment by Michael Sevakis (MikeS) - Sunday, 11 November 2007, 04:55 GMT+2
We just need to set inputs properly on the WM chip then? I left a TODO: in there in audiohw_set_monitor.
Comment by Barry Wardell (barrywardell) - Sunday, 11 November 2007, 13:54 GMT+2
I've implemented audiohw_set_monitor() from my understanding of the WM8731 datasheet.

I also changed audio_set_recvol() to set the volume to 0dB. It makes sense to me that it should be set that way. Is there any reason it was set to -34.5dB (LINVOL = 0) previously?

Still no success, however. Turning the volume up to max, I can hear faint random noise, which does respond slightly to changing station.
   h10-radio_8.patch (7 KiB) 
 apps/recorder/radio.c                      |    4 ++++
 apps/keymaps/keymap-h10.c                  |   23 ++++++++++++++++++++++-
 firmware/export/config-h10.h               |    6 +++---
 firmware/export/config-h10_5gb.h           |    6 +++---
 firmware/SOURCES                           |    2 ++
 firmware/target/arm/audio-pp.c             |    3 ++-
 firmware/target/arm/iriver/h10/power-h10.c |   13 ++++++++++---
 firmware/drivers/audio/wm8731.c            |   13 +++++++++++--
 8 files changed, 57 insertions(+), 13 deletions(-)

Comment by Barry Wardell (barrywardell) - Sunday, 11 November 2007, 17:03 GMT+2
I've just committed this version of the patch to SVN. The problem as suggested by jhMikes on IRC was that the setting of the bit in GPIOB2 was backwards
   h10-radio_9.patch (0 KiB) 
 0 files changed

Loading...