Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8168 - Status Bar Remains After Shutdown/Poweroff From FM Radio Screen

Attached to Project: Rockbox
Opened by Marc Guay (Marc_Guay) - Friday, 16 November 2007, 03:08 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Thursday, 10 January 2008, 07:46 GMT+1
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player type Sansa e200
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

r15632
Sansa e200

The "statusbar: off" line is removed from the config.cfg file if the player is shut down from inside the FM radio screen, where it has been turned on automatically. Is it possible to have the settings not save under this condition? Or have them only saved if changed manually?

Recipe:

FM Radio -> Preset Menu or FM Radio Menu -> Shutdown

or

FM Radio -> Pause/Mute -> Let Idle Poweroff do it's thing


This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 10 January 2008, 07:46 GMT+1
Reason for closing:  Fixed
Comment by Jonathan Gordon (jdgordon) - Friday, 16 November 2007, 03:27 GMT+1
this patch probably fixes it.. but I dont have a radio target.
   radiofix.patch (0.4 KiB)
Comment by Scott Tinman (sctinman) - Wednesday, 09 January 2008, 08:07 GMT+1
I was able to reproduce with r16029 on both the simulator and on e200. Your patch worked, but only on the simulator, I was still able to reproduce on my e200 by going Radio->Preset Menu->Hold Power till shutdown

Maybe that's why it didn't work? Since the button press was in the preset menu, and your patch was for the radio screen.
Comment by Scott Tinman (sctinman) - Thursday, 10 January 2008, 01:17 GMT+1
This seems like it may be harder to fix than I thought. Since the power down is in a different thread, I'd assume event queues would have to be used. Am I correct, or is their an easier way to tell what the power thread is doing =P
Comment by Scott Tinman (sctinman) - Thursday, 10 January 2008, 07:28 GMT+1
progress...
   statusbar.patch (3 KiB)

Loading...