Rockbox

Tasklist

FS#8169 - Inconsistent Sansa Keymappings

Attached to Project: Rockbox
Opened by Marc Guay (Marc_Guay) - Friday, 16 November 2007, 02:29 GMT
Last edited by Paul Louden (Llorean) - Tuesday, 20 November 2007, 01:57 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

r15632
Sansa e200

The keymap was changed for the WPS on the Sansa recently but the changes didn't trickle over to the other screens, namely Recording and FM Radio, leading to some inconsistencies.

The new keys are generally:
LONG-SELECT = CONTEXT MENU
POWER = STOP
DOWN = RETURN TO MAIN MENU

In the recording screen currently:
DOWN = CONTEXT MENU
LONG-SELECT = NOTHING

I propose:
DOWN = STOP & RETURN TO MAIN MENU (SAME AS POWER?)
LONG-SELECT = CONTEXT MENU

and in the FM Radio screen currently:
DOWN = CONTEXT MENU
POWER = RETURN TO MAIN MENU WITHOUT STOPPING AUDIO

I propose:
DOWN = RETURN TO MAIN MENU WITHOUT STOPPING AUDIO
LONG-SELECT = CONTEXT MENU
POWER = STOP AUDIO AND RETURN TO MAIN MENU


---

I find the more I get used to the new keymap while listening to audio files the more confused I get in other parts of the player. Consistency is a good thing, no?
This task depends upon

Closed by  Paul Louden (Llorean)
Tuesday, 20 November 2007, 01:57 GMT
Reason for closing:  Fixed
Additional comments about closing:  Keymaps for FM Radio, Recording, and Text viewer (only a tiny change to the latter) brought into line with Rockbox standard buttons.
Comment by Jonathan Gordon (jdgordon) - Sunday, 18 November 2007, 11:44 GMT
I agree that the keymap has to stay consistant so ive had a very quick go at fixing the rec screen.. but i dont actually use it so i dont know if its any better. (and my sansa doesnt have fm so i havnt fixed that either)

Index: apps/keymaps/keymap-e200.c
===================================================================
--- apps/keymaps/keymap-e200.c (revision 15654)
+++ apps/keymaps/keymap-e200.c (working copy)
@@ -208,8 +208,10 @@
static const struct button_mapping button_context_recscreen[] = {
{ ACTION_REC_PAUSE, BUTTON_UP|BUTTON_REL, BUTTON_UP },
{ ACTION_STD_CANCEL, BUTTON_POWER|BUTTON_REL, BUTTON_POWER },
+ { ACTION_STD_CANCEL, BUTTON_DOWN, BUTTON_NONE },
{ ACTION_REC_NEWFILE, BUTTON_REC|BUTTON_REL, BUTTON_REC },
- { ACTION_STD_MENU, BUTTON_DOWN|BUTTON_REPEAT, BUTTON_NONE },
+ { ACTION_NONE, BUTTON_SELECT, BUTTON_NONE },
+ { ACTION_STD_MENU, BUTTON_SELECT|BUTTON_REPEAT, BUTTON_SELECT },
{ ACTION_SETTINGS_INC, BUTTON_RIGHT, BUTTON_NONE },
{ ACTION_SETTINGS_INC, BUTTON_RIGHT|BUTTON_REPEAT, BUTTON_NONE },
{ ACTION_SETTINGS_DEC, BUTTON_LEFT, BUTTON_NONE },

Loading...