Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8207 - buildzip.pl cleanup

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Wednesday, 21 November 2007, 20:35 GMT+2
Last edited by Jonas Häggqvist (rasher) - Monday, 21 July 2008, 00:39 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To Jonas Häggqvist (rasher)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is my first stab at converting buildzip.pl to use native perl functions, rather than calling external apps (causing a pretty hefty slowdown on cygwin). So far, I've simply gone for the low-hanging fruit - simple cp and mv operations.

A recursive delete function should be fairly simple (to replace "rm -rf").

The next step is probably to write a sort of "find" implementation that takes a search expression and a callback function or something like that. It doesn't need to be a full find replacement of course. Just enough to do what buildzip needs (find and copy, I believe).

This will need a fair bit of testing of course, since we don't want the zips to be broken.
   buildzip-cleanup-fs8207.diff (4.5 KiB) 
 buildzip.pl |   36 +++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Monday, 21 July 2008, 00:39 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r18108
Comment by Jonas Häggqvist (rasher) - Sunday, 20 July 2008, 23:11 GMT+2
Updated patch. Most things have been changed from shelling out to using Perl functionality.

Hopefully this provides a nice speedup.

I *think* this produces identical zip files to current SVN.
   buildzip-cleanup-fs8207-v2.diff (7.3 KiB) 
 tools/buildzip.pl |   85 +++++++++++++++++++++++++++++++++---------------------
 1 file changed, 53 insertions(+), 32 deletions(-)

Comment by Jonas Häggqvist (rasher) - Monday, 21 July 2008, 00:10 GMT+2
Fixed a few issues:
- Cleanup .cp files
- Remove a leftover printf
- Actually create .rockbox/database.ignore
- Pipe all zip output to /dev/null
   buildzip-cleanup-fs8207-v3.diff (7.5 KiB) 
 tools/buildzip.pl |   94 +++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 61 insertions(+), 33 deletions(-)

Loading...