Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8234 - mpegplayer - fixed set start time slider

Attached to Project: Rockbox
Opened by Brian Morey (Morey) - Tuesday, 27 November 2007, 03:43 GMT+2
Last edited by Nils Wallménius (nls) - Monday, 07 April 2008, 13:32 GMT+2
Task Type Patches
Category Video
Status Closed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch fixes the issue where the slider blinks when scrolling to set a start time from the mpegplayer start menu.

Apply the patch then add the .bmp file to
"apps/plugins/bitmaps/native/"

The slider in it's current state is kind of annoying, this patch makes the slider smooth.
   mpeg_svn15831_r4.patch (5.4 KiB)
   mpegplayer_slider.8x8.bmp (0.8 KiB)
This task depends upon

Closed by  Nils Wallménius (nls)
Monday, 07 April 2008, 13:32 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Closed on request by poster.
Comment by Brian Morey (Morey) - Tuesday, 27 November 2007, 03:44 GMT+2
Is there a way to include a binary image in the patch file? As in the case of the above image.
Comment by Brian Morey (Morey) - Friday, 14 December 2007, 04:14 GMT+2
svn sync
   mpeg_svn15923_r1.patch (5.4 KiB)
Comment by Michael Sevakis (MikeS) - Friday, 14 December 2007, 09:16 GMT+2
In my reworking there is no blinking so that will be a non-issue since I had to work on it to use the updated image interface. Time is displayed in hh:mm:ss with "hh" left off if the duration doesn't go that high. Current time on the left, duration on the right (no zero on the left - why bother?). It also takes the full screen width minus a 1px border. I rather like the screen as a movie browser so no matter that seeking is enabled during playback it will stick around. It also has potential as much more and extracting frames at precise times is simple now despite that MPEG makes it a PITA to implement even with frequent GOP headers.
Comment by Brian Morey (Morey) - Friday, 14 December 2007, 17:28 GMT+2
That all sounds great. When your rework gets commit feel free to close this task.
Comment by Michael Sevakis (MikeS) - Saturday, 15 December 2007, 02:29 GMT+2
That's supposed to be a film strip image to fill the bar instead of just solid fill? I definitely want things to set it apart visually after the nitty-gritty stuff is stable and verified.

Loading...