Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8295 - database integration of pictureflow

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Monday, 10 December 2007, 23:57 GMT+2
Last edited by Robert Kukla (roolku) - Tuesday, 11 December 2007, 00:40 GMT+2
Task Type Patches
Category Database
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This is the first step of being able to use the pictureflow plugin from a database search. The database now indexes the path to the coverimage for each audio file. In the database browser you can select "Cover by..." genre, artist, composer, year or all and will be presented with a list of cover image paths. (Imagine a call to the pictureflow plugin at this stage, so instead of a list of boring paths you get nice and shiny images). After selecting a path it will display the list of files that would be queued when a cover image is picked in the plugin.

Next step is to work out how to safely call the plugin without losing the context and utilise the return value from it to queue the files.

Issues so far are:

- the preferred size of 100x100 is hardcoded (this should be configurable or at least be consistent with the value in the pictureflow plugin?)
- the db update for covers has the same restrictions as the other tags, i.e. it will only detect changed cover art on initialise
- the coverflow plugin needs to work while music is playing (or stop playback if needs be)
- since there is no guaranteed relation between album name and image file, the album name can't be displayed
   db+pictureflow_step1.patch (5.5 KiB) 
 apps/tagcache.c     |   18 +++++++++++++-----
 apps/tagcache.h     |    9 +++++----
 apps/tagnavi.config |    9 +++++++++
 apps/tagtree.c      |    1 +
 4 files changed, 28 insertions(+), 9 deletions(-)

This task depends upon

Comment by Thomas Schott (scotty) - Wednesday, 27 August 2008, 22:51 GMT+2
sync to SVN (r18351)
   db+pictureflow_step1.patch (5.4 KiB) 
 apps/tagcache.c     |   17 ++++++++++++-----
 apps/tagcache.h     |    9 +++++----
 apps/tagnavi.config |    9 +++++++++
 apps/tagtree.c      |    1 +
 4 files changed, 27 insertions(+), 9 deletions(-)

Comment by Robert Kukla (roolku) - Wednesday, 22 October 2008, 21:02 GMT+2
Sync and do not search for ".100x100" (it will only find covers without explicit size now)
   db+pictureflow_step1b.patch (5 KiB) 
 apps/tagcache.c     |   15 +++++++++++----
 apps/tagcache.h     |    7 ++++---
 apps/tagnavi.config |    9 +++++++++
 apps/tagtree.c      |    1 +
 4 files changed, 25 insertions(+), 7 deletions(-)

Comment by Taylore (trailblaze) - Saturday, 07 March 2009, 21:03 GMT+2
This is a wonderful start, but how hard would it be to do this- but in PictureFlow.
That's the only thing lacking in Pictureflow so far, is being able to actually play the song.
But isnt it hard to access the database and load PictureFlow at the same time?

Loading...