Rockbox

Tasklist

FS#8320 - Incorrect song information is displayed for songs when switching between several songs fast

Attached to Project: Rockbox
Opened by Alex (Sanek) - Friday, 14 December 2007, 06:08 GMT
Last edited by Steve Bavin (pondlife) - Friday, 18 April 2008, 05:34 GMT
Task Type Bugs
Category Music playback
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I've noticed a problem while going through the songs in the playlist, if you go through the songs fast enough without allowing for the fade in/out effect to apply, the songs playing and the song titles get offset from each other.

For example: If I select to listen to the a playlist with 30+ songs and if I quickly switch to the 10th song by pressing the NEXT button on the iPod, the title of the song shown would be of a previous song that I skipped already, while the song playing would be the correct one.

So if you had songs A, B, C, D, E, F, G, H, I, J, K in your playlist (in that order) and you were to quickly switch to song J, the title of song H or I would be shown on the screen, while song J would be the one playing. So you could have the title for one song displayed on the ipod and a completely different song playing.

I was able to recreate this problem with both current build (r15920-071213) and last week's build.

I have also confirmed that the problem corrects itself when the current song finishes playing and switches to the next song in the playlist automatically.

You can do the following to recreate the problem:
1) Download Rockbox current build and extract it to the ipod.
2) Boot into Rockbox and initialize the database, reboot again to use it.
3) Open an album from the database that contains a fair amount of songs (the resulting playlist needs to have 10-15+ songs).
4) Select a song from the resulting playlist, make sure that its the correct song playing.
5) Quickly press ">>" (NEXT) button several times (10 or 15 times).
6) You will start seeing the screen trying to catch up and when it finally does, the song information displayed on the screen should not match the song that is actually playing. You may need to press next/previous buttons a few more times to see this behavior.

I am listening to .mp3 files which were sorted into folders by iTunes with iTunes-specific cryptic filenames. Rockbox displays id3 information for these files, so thats the part that is getting displayed incorrectly and goes "out of sync" with the actual song playing.
This task depends upon

Closed by  Steve Bavin (pondlife)
Friday, 18 April 2008, 05:34 GMT
Reason for closing:  Fixed
Comment by ryan r (ralfonso) - Thursday, 27 December 2007, 17:24 GMT
I have this same problem on a Gigabeat F40. I used a custom build from code pulled on 2007-12-26
Comment by Charles (Detritus) - Sunday, 30 December 2007, 13:36 GMT
Also occurs on Sansa E260 with build downloaded Dec 28 2007
Comment by Marc Guay (Marc_Guay) - Thursday, 24 January 2008, 21:25 GMT
r16150 - Sansa e200 - Confirmed. Album art & ID3 tags sometimes not displayed properly as well as occasional mislabelling of current song. Pretty minor bug though as it's easier to scroll through the playlist and choose the file you want to start with anyway.
Comment by Nicolas Pennequin (nicolas_p) - Saturday, 26 January 2008, 01:44 GMT
This patch should fix the WPS inconsistencies, but I'm afraid it might have other undesirable side effects, including bad skipping responsiveness when buffering is in progress.
Please test and report :)
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 06 February 2008, 20:53 GMT
Has anyone tested the patch?
Comment by Alex (Sanek) - Thursday, 07 February 2008, 05:52 GMT
I will test it tomorrow and post the results here.
Comment by Alex (Sanek) - Saturday, 09 February 2008, 08:17 GMT
I'm having problems compiling for some reason, so I'll try to figure out what the problem is.

In the middle of the compiling process, I get the following errors:
MAKE in <<<<<<<
/bin/sh: -c: line 0: syntax error near unexpected token `<<<'
/bin/sh: -c: line 0: `mkdir -p /rockbox/build/apps/plugins/<<<<<<<'
make[2]: *** [<<<<<<<] Error 2

...

make[1]: *** [rocks] Error 2
make: *** [build] Error 2

The patch was applied to the latest svn, however I don't think its patch-related.
I'll get the latest svn again to see if I am able to recompile it again.
Comment by Alex (Sanek) - Saturday, 09 February 2008, 09:32 GMT
OK, I recompiled everything and patched without any problems with a clean svn.

About the patch: When I press the NEXT button for the first time, it takes effect about 1-2 seconds after I pressed it. When I press it again after that, it either takes a very long time to react (10+ seconds) when buffering or reacts right away when the buffering is done.

Unfortunately, I think this makes things even worse since now it just doesn't let me skip through 5-10 songs fast by pressing the NEXT button, so I have to wait until it finishes buffering every single song, which takes a while.
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 26 February 2008, 17:20 GMT
This should be better with r16425.
Comment by Abc Def (hoho) - Tuesday, 26 February 2008, 18:11 GMT
It is much better, its updating fast, but if you skip ~4-5 tracks at once fast it stops, goes back to the database/file view.
Comment by Abc Def (hoho) - Tuesday, 26 February 2008, 18:14 GMT
More like ~7-8 tracks even, happens more often then.
Comment by Abc Def (hoho) - Tuesday, 26 February 2008, 18:45 GMT
Looks like it happens when rockbox tries to start playback again and i havent finished skipping.
I skip 4-8 tracks, the playback stops at start of skipping, then somewhere between 4-8 tracks it tries to start playback again, it slows down a little and gets less responsive, and then it either continues skipping or exits to menu.
And I have a suspicioun the playlist index still gets mixed up. Sometimes when skipping backwards it suddenly jumps from track 5 to 1, the key presses were well counted, it shouldnt have jumped that much.
Comment by Abc Def (hoho) - Tuesday, 26 February 2008, 18:47 GMT
Im using Sansa e260 - r16425
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 26 February 2008, 21:31 GMT
hoho: Does it still happen with r16430?
Comment by Abc Def (hoho) - Tuesday, 26 February 2008, 22:30 GMT
r16430, the stoping and falling out to menu is gone, the skipping is mostly good.
Though it is still not consistent with the key presses on more skips, after 4 or 5 skips a keypress or two go unnoticed,rockbox doesnt respond. Happens both forwards and backwards.

And I managed to get it to hang completely once, but that was under pretty extreme conditions, kept skipping from begging to end and vice versa very fast.
Comment by Marc Guay (Marc_Guay) - Friday, 04 April 2008, 04:39 GMT
This seems to be fixed with r16948. But other problems have morphed, see  FS#8674 . Edit: I just pushed this to the absolute limit (skipping like a fiend through a 100+ playlist) and couldn't get the player to freeze or have the tracklisting fall out of sync with the music.
Comment by Alex (Sanek) - Saturday, 05 April 2008, 02:44 GMT
Hmm... I'll test it out on the weekend when I get some free time :)

Thanks!
Comment by Nicolas Pennequin (nicolas_p) - Thursday, 17 April 2008, 17:00 GMT
What about now?
Comment by Marc Guay (Marc_Guay) - Thursday, 17 April 2008, 23:38 GMT
e200 + r17153 = Supergreat!

Loading...