Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8335 - album title config & small improvoments for PictureFlow

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Sunday, 16 December 2007, 16:25 GMT+2
Task Type Patches
Category Plugins
Status Unconfirmed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch adds a setting to the pictureflow plugin.

The setting named "Show album titles" lets the user dicide where to show the album titles

*hide album titles
*show at the bottom
*show at the top

(show at the bottom is default)

For people knowing there albums very well hide is the best option. For all others "show at the top" is the best option (imo), since it it doesn't destroy the beautiful reflections of the cover with overlapping album titles.

The track list (after selecting a cover) is moved downwards by 30 pixels, when the title is set to be shown at the top, so that the album title doesn't overlap with the track list.

Small improvements are:
*correct the zoom settings menu to be called Zoom (it was "Number of slides")
*move the track list downwards by 30 pixels when show fps is enabled to not overlap the track list
(IMO it looks better in any case when the track list is moved downwards a bit, but I didn't want to change to much at once)
   pf_album_title_v1.diff (4 KiB)
This task depends upon

Comment by Thomas Martitz (kugel.) - Monday, 17 December 2007, 02:30 GMT+2
Ok, next version. This should be ready to commit. I've tested it deeply on my e200. I've added an exception for smaller screens (height < 100) like c200's, though I think pictureflow should be more optimized for small screens in general.


Overall improvement concering the tracklist:
*full screen tracklist if both album titles and fps are hidden
*move the tracklist if album titles and/or fps are shown, including reducing the number of visible items
   pf_album_title_v2.diff (5.5 KiB)
Comment by Thomas Martitz (kugel.) - Monday, 17 December 2007, 02:35 GMT+2
Just fixed a few typos in comments, and added one. No functional change.
Comment by Thomas Martitz (kugel.) - Monday, 17 December 2007, 02:35 GMT+2
Here's the file.
   pf_album_title_v2b.diff (5.6 KiB)
Comment by Thomas Martitz (kugel.) - Tuesday, 18 December 2007, 23:56 GMT+2
No fuctional change. Made an enum for show_album title for easier-to-read-code, some changes to the comments.
   pf_album_title_v3.diff (5.7 KiB)
Comment by Thomas Martitz (kugel.) - Sunday, 11 May 2008, 05:50 GMT+2
Sync and implement smooth_resize. Problem: It doesn't resize.
Comment by Thomas Martitz (kugel.) - Sunday, 11 May 2008, 05:51 GMT+2
Here's the patch.
   pf_album_title_v4.diff (6.1 KiB)
Comment by Thomas Martitz (kugel.) - Saturday, 17 May 2008, 05:16 GMT+2
Ok, I got resize to work. Doing this, I also introduced a setting to let the user decide if covers should be resized (default is yes). Like before, on color targets, smooth resize is used (on other simple resize).

Secondly, I changed a bit how PREFERRED_IMG_HEIGHT/_WIDTH are calculated. It's now dependent on the screen size instead of a fixed size (e.g. a Gigabeat F/X defaults to 150 height and width). Also, this values will be used for resizing.
NOTE: Resizing will not keep the aspect ratio. If this behavior isn't wanted, please comment on that.

Thirdly, I fixed (or at least worked around) the wrong order of tracks in the tracks list ( FS#8425 ). It's maybe a bit dirty, but I noticed that the tagcache search for the track titles returned the results in the wrong order. My fix is to "invert" the track index when getting the names from the index.

This patch also moves show_fps into the config struct.

This patch also fixes  FS#8347  by forcing the track list to reset upon selecting the album.

The only tracker entry which doesn't get fixed is FS#8927 :) ( FS#8326  doesn't seem to happen anymore)


If there are no objections anymore I'm done with this patch, it should be ready for commit. I hope I didn't change too much at once. If I did I could consider splitting it up a bit.
   pf_album_title_v5.diff (10.2 KiB)
Comment by Thomas Martitz (kugel.) - Saturday, 17 May 2008, 18:06 GMT+2
Hold on, after some talk with Slasheri, the track search isn't reliable at all (in terms of ordering). So, my fix is as worse as the original implemntation.

Slashery said the inverted order I get comes most likely from the filesystem which returns the files in some order. I have named my tracks to have the track number leading, so they are if they are ordered by name they are also ordered by track number.
Comment by Thomas Martitz (kugel.) - Saturday, 17 May 2008, 18:42 GMT+2
So, this simply removes the attempt to order the tracklist correctly.

More needs to be done to give it an order. Until then the tracklist is more or less random.

I'm not even sure if the tracklist was intended to be ordered.
   pf_album_title_v6.diff (9.8 KiB)
Comment by Thomas Martitz (kugel.) - Tuesday, 24 June 2008, 16:54 GMT+2
Sync, also fix a bug introduced r17781 (1 track missing in the tack list).
   pf_album_title_v7.diff (9.8 KiB)
Comment by Thomas Martitz (kugel.) - Tuesday, 24 June 2008, 16:58 GMT+2
Sync, also fix a bug introduced r17781 (1 track missing in the tack list).
   pf_album_title_v7.diff (9.8 KiB)
Comment by Thomas Martitz (kugel.) - Tuesday, 24 June 2008, 17:21 GMT+2
Ok, I've noticed the covers were a bit too small on a screen like the one of the h300.

I changed PREFERRED_IMG_WIDTH and _HEIGHT to LCD_HEIGHT / 2 now. This should be fine with the committed smooth scaling. Also, it only uses this when resizing is enabled.
   pf_album_title_v8.diff (9.8 KiB)
Comment by Jonathan Gordon (jdgordon) - Sunday, 29 June 2008, 04:26 GMT+2
this patch still doesnt work for me.... even after removing the cache folder

Loading...