Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8395 - Thai Language Update

Attached to Project: Rockbox
Opened by Prakarn Sahasoontornvute (note8825) - Thursday, 03 January 2008, 08:55 GMT+2
Last edited by Jonas Häggqvist (rasher) - Sunday, 13 January 2008, 23:25 GMT+2
Task Type Patches
Category Language
Status Closed
Assigned To Jonas Häggqvist (rasher)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date 2008-01-11
Percent Complete 100%
Private No

Details

Latest update for Thai language.
   thai.diff (9.1 KiB) 
 apps/lang/thai.lang |  336 +++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 320 insertions(+), 16 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Sunday, 13 January 2008, 23:25 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r16086.
Comment by harry tu (bookshare) - Thursday, 03 January 2008, 17:11 GMT+2
The thai language is sufficiently big that I had to increase the size of the language buffir. I just did so. Oh, and by the way Prakarn, do the characters display correctly in rockbox itself? The previous translator said the characters wouldn't so I wanted to check again.
   thai.patch (9.2 KiB) 
 apps/language.h     |    2 
 apps/lang/thai.lang |  336 +++++++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 321 insertions(+), 17 deletions(-)

Comment by Prakarn Sahasoontornvute (note8825) - Thursday, 03 January 2008, 19:45 GMT+2
I don't know much about patching (just want to translate it ^_^ ).
http://www.unicode.org/charts/PDF/U0E00.pdf <<< please take a look at this chart, it'll help you understand what i'm going to explain.

Many Thai characters (such as Vowels, Tone Marks) have to place over or under the alphabets (consonants).
I'll show you the example with my drawing.
This picture contain with 3 chracters (0E19 + 0E39 + 0E4B)
http://xs123.xs.to/xs123/08014/nocorrectly.JPG <<< this's how it shown on rockbox.
http://xs123.xs.to/xs123/08014/correctly.JPG <<< here's the correct display.

Sometime it'll have 2 characters over the alphabet vowels+tone marks (tone marks are always on the top of the vowels).
This picture contain with 3 chracters (0E19 + 0E35 + 0E49)
http://xs123.xs.to/xs123/08014/Notcorrect2.JPG <<< this's how it shown on rockbox.
http://xs123.xs.to/xs123/08014/correct2.JPG <<< here's the correct display.

Sorry that I can't explain you much because my bad English. ^_^
   correctly.JPG (6.4 KiB)
Comment by harry tu (bookshare) - Thursday, 03 January 2008, 21:09 GMT+2
and also, isn't the lang name of thai actually pasathai?  FS#7637  is a debate on localizing language names and I am trying to get more names
than I already have. I thought I should check with someone who actually knows thai.
Comment by harry tu (bookshare) - Thursday, 03 January 2008, 21:10 GMT+2
And thanks for the explanation. And your english is pretty good.
Comment by Prakarn Sahasoontornvute (note8825) - Friday, 04 January 2008, 07:01 GMT+2
The word "pasa" mean "language" in Thai, so it's ok to use only "Thai" for lang name. ^_^
Comment by harry tu (bookshare) - Saturday, 05 January 2008, 00:25 GMT+2
ok
Comment by Prakarn Sahasoontornvute (note8825) - Saturday, 05 January 2008, 16:34 GMT+2
Oh.. I forgot to translate <Random> in LANG_TAGNAVI_RANDOM.

Here's the new one.
   thai.diff (9.1 KiB) 
 apps/lang/thai.lang |  336 +++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 320 insertions(+), 16 deletions(-)

Comment by Mustapha Senhaji (DrMoos) - Saturday, 05 January 2008, 16:38 GMT+2
OK, is this the last update? If so we will commit it.
Comment by Prakarn Sahasoontornvute (note8825) - Saturday, 05 January 2008, 16:42 GMT+2
Yes, that's all. ^_^
Comment by harry tu (bookshare) - Saturday, 05 January 2008, 18:00 GMT+2
Don't commit it yet. I don't think some targets' thai language will work. I need to increase the size of the lang buffir.
Comment by harry tu (bookshare) - Saturday, 05 January 2008, 18:56 GMT+2
This patch should do it.
   lang.diff (0.5 KiB) 
 apps/language.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment by Prakarn Sahasoontornvute (note8825) - Saturday, 12 January 2008, 06:43 GMT+2
Add "LANG_BUTTONLIGHT_TIMEOUT" translation.
   thai.diff (9.7 KiB) 
 apps/lang/thai.lang |  342 +++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 323 insertions(+), 19 deletions(-)

Comment by harry tu (bookshare) - Sunday, 13 January 2008, 11:55 GMT+2
What's the hold up?
Comment by Jonas Häggqvist (rasher) - Sunday, 13 January 2008, 18:13 GMT+2
Lack of time. I'll get around to it - sooner rather than later probably.

Loading...