This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#8396 - next_dir within playlist
Attached to Project:
Rockbox
Opened by Lee Kang Hyuk (alwaysbluepop) - Thursday, 03 January 2008, 09:10 GMT+2
Opened by Lee Kang Hyuk (alwaysbluepop) - Thursday, 03 January 2008, 09:10 GMT+2
|
DetailsThis patch is inspired by FS7571.
Currently we can move to next/prev directory with <short left/right + long left/right>. This patch changes two part of this functionality: 1. If <Auto-Change Directory> is not enabled, move to first track of current/next directory only within the playlist. So you can maintain dynamic playlist. This was very annoying problem for me. 2. do not wait till <long left/right> is released. So ffwd or rewind will not be performed at new track. 
albumskip.patch
(6.2 KiB)
apps/playlist.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++ apps/playlist.h | 2 + apps/gui/gwps-common.c | 12 +++++++- apps/gui/gwps.c | 17 ++++++++++- apps/gui/gwps.h | 1 5 files changed, 102 insertions(+), 3 deletions(-) |
This task depends upon
Some comments:
1) You need to localize the strings in the syncsplashes, using the language files
2) Are the "first/last album" splashes really necessary?
3) I think it should continue playing the current track if it fails to find a new directory
1, 2: removed the splashes. i thought the machine should inform users why expected behaviour is not carried out.(as you mentioned, like move-to-bottom)
3: how about this one? 'Circulate through playlist only when repeat mode is not set to off'. Actually that was what i really intended to do. :)
and 4: Suppose there are a1, a2, b1, b2, and c in playlist. When playing a2, <short press>+<long press> results in c, instead of b1. Fix this by retrieving index-1.
p.s> i can't keep playback from skipping since <short press> is prior to any other thing. So i decided to leave it go to next track. Maybe DoubleClick feature would be the best solution.
Changes:
1. It is now triggered by <Long + Short Press>. <short + long> will do their individual job.
2. Independent from 'Auto-Change Directory'. Instead, use new option 'Directory Skip by Keypress' in playback settings menu.
Default value is 'within-playlist' mode.
3. Do nothing when there are no next-dir.
Now builds fine.
---------------------------
Description:
This patch adds new setting 'Directory Skip' under 'Playback Settings'. This setting determines what to do when user pressed <short left/right> followed by <long left/right> in WPS.
There are three options:'Within Playlist', 'Next Directory', and 'Off'. Default value is 'within pl'.
1. Within Playlist: When pressed <long+short right>, go to the first track of the playlist which has a different filepath from current track.
When pressed <long+short left>, go to the first track of the playlist which has a same filepath with current track.
2. Next Directory: Play prev/next directory's tracks, erasing current dynamic playlist. (This is the same behaviour as what current svn does, by pressing <long+short left/right>.)
3. Off: Do nothing. (only 'seek forward/backward' will be performed)
Exceptions:
- If repeat mode is 'ONE' or 'A-B', do nothing.
- If repeat mode is 'ALL', and user pressed <long+short right> while there are no more different filepath, go to first track of the playlist.
Thanks for fixing, I'll check it out.
The next directory setting does work.
playlist_prev_album() is changed slightly: if playing the first three seconds of the first track, move to previous album. (similar as normal LEFT does).
Since study mode(
FS#6188) (which is included from r17355) uses <short left + long right> to skip to the next track, I had to change this too. (long left + short right to SKIPNEXT)Maybe I should give up <long + short>, but decided to stick on it. Using <short + long> is obstacle when i want to go to the middle of next track. Moreover it plays unwanted track about a second.
I'll attach a 'short+long'version anyway. Works same except for key triggers. No seeking at a new track.
Example:
You have a list of multiple directories. You can jump directories with the patch, but it works within the playlist.
Next directory works if you aren't using a playlist. Example: you went into your file browser and selected a directory to play.
You only need one file included in the patch. Depending on WHICH key combo you like better. Long+short (my preference) or short+long.
Hope that wasn't too confusing. Also, i hope that my explanation was correct. :)
one patch uses long + short.. the other uses short + long (different sequence). They both perform the same function, just the order of the keypress that you prefer.
if you use a dynamic playlist, use the next directory option. (I like to use it in conjunction with random folder advance, but that's me)