Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8436 - Music Patche that makes the wheel LED's blink to the beat of the music

Attached to Project: Rockbox
Opened by ian (AssassinXCV) - Wednesday, 09 January 2008, 02:05 GMT+2
Last edited by Alex Parker (BigBambi) - Sunday, 06 June 2010, 12:08 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

hey, can you add this patch please, it makes the LED's in the Wheel blink to the beat of the music
   music_led.patch (0.4 KiB) 
 peakmeter-e.c |    6 ++++++
 1 file changed, 6 insertions(+)

This task depends upon

Closed by  Alex Parker (BigBambi)
Sunday, 06 June 2010, 12:08 GMT+2
Reason for closing:  Rejected
Comment by Paul Louden (Llorean) - Wednesday, 09 January 2008, 02:11 GMT+2
I see no option to enable or disable this... this patch isn't really suitable for inclusion at all in its current state. You'll need to make it at least optional and flexible.
Comment by Dagni McPhee (donutman25) - Wednesday, 09 January 2008, 04:16 GMT+2
This patch looks familiar(because i'm the one that created it). If AssassinXCV doesn't work on the menu integration by saturday i will do it.

Bahamas<=Sun,Sand,Sea,Me
Comment by Paul Louden (Llorean) - Wednesday, 09 January 2008, 04:19 GMT+2
Is there already another tracker entry for this?
It's really, really bad to submit other peoples' patches to the tracker.
Comment by Dagni McPhee (donutman25) - Thursday, 10 January 2008, 01:31 GMT+2
There was a tracker entry for it but i guess you guys removed it during your tracker cleanup. Its really no problem to me if he added it again but if you have a problem with it then do as you please.
Comment by ian (AssassinXCV) - Thursday, 10 January 2008, 02:05 GMT+2
Sorry, i got it from someone on a website that respects Rockbox, just to let you know, i am not going to take credit for the Patch
Comment by ian (AssassinXCV) - Thursday, 10 January 2008, 02:06 GMT+2
oh ya, i don't know how to integrate it so do as you please
Comment by Paul Louden (Llorean) - Thursday, 10 January 2008, 04:49 GMT+2
The point was more "You need to be able to release the work under the GPL license, and thus must have permission to do so." His posting of someone else's work is a bad thing to do unless there's a license that goes with it allowing him to allow its use under the GPL.

As for technical details, what I said in my first comment still stands in order for anyone to consider it.
Comment by ian (AssassinXCV) - Friday, 11 January 2008, 00:34 GMT+2
Please just put it in, i don't want any trouble, i just want to have that patch put in. I DO NOT WANT TO TAKE AWAY ANY CREDIT FROM THE CREATOR OF THE PATCH, sorry if it has bothered you, i didn't know, it was a mistake, i just got it off a website, i didn't know SORRY, i just want to have the patch "integrated" what ever that means. Sry! And i'm not good at changing around stuff,(i'm not good at computer stuff) can you make all the otions like to turn it off or on and do that "flexible" stuff.
Comment by ian (AssassinXCV) - Friday, 11 January 2008, 00:42 GMT+2
Sorry Donut Man 25 i didnt want to cause any problems, maybe your the one that posted the patche on the website that i'm talking about, have you ever been to the site www.thesansa.com? it has themes to use on rockbox and themes just for regular sansa if you don't have rockbox. plus it has tricks and stuff for the sansa, you should go to it, there are some very smart people there, oh and the site is mostly a forum site that people post things so try it out you guys. Donut man, if you can integrate it then please do it
Comment by silvio (talent) - Tuesday, 22 January 2008, 19:10 GMT+2
so, wehn you can't enable this patch, it don't really work,no ?

Loading...