This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#8443 - Cabbie 2.0 Default Theme
Attached to Project:
Rockbox
Opened by ApooMaha (crzyboyster) - Thursday, 10 January 2008, 23:32 GMT+2
Last edited by Steve Bavin (pondlife) - Monday, 07 April 2008, 11:38 GMT+2
Opened by ApooMaha (crzyboyster) - Thursday, 10 January 2008, 23:32 GMT+2
Last edited by Steve Bavin (pondlife) - Monday, 07 April 2008, 11:38 GMT+2
|
DetailsHere is the final (or near final) release of Cabbie 2.0!
# Name of the WPS (_including_ .wps extension) Name.320x240x16: cabbie default-320x240x16.wps Name.240x320x16: cabbie default-240x320x16.wps Name.220x176x16: cabbie default-220x176x16.wps Name.176x220x16: cabbie default-176x220x16.wps Name.176x132x16: cabbie default-176x132x16.wps Name.160x128x16: cabbie default-160x128x16.wps Name.160x128x2: cabbie default-160x128x2.wps Name.138x110x2: cabbie default-138x110x2.wps Name.128x128x16: cabbie default-128x128x16.wps Name.132x80x16: cabbie default-132x80x16.wps Name.112x64x1: cabbie default-112x64x1.wps # Real name of the creator of the WPS Author: Johannes Voggenthaler # Preferred font (including .fnt extension - leave blank for player): Font.320x240x16: helvr12.fnt Font.240x320x16: helvr14.fnt Font.220x176x16: helvr10.fnt Font.176x220x16: helvr10.fnt Font.176x132x16: helvr10.fnt Font.160x128x16: helvr10.fnt Font.160x128x2: mix12.fnt Font.138x110x2: helvR10.fnt Font.128x128x16: helvR10.fnt Font.132x80x16: Sazanami-Mincho-Regular-11.fnt Font.112x64x1: rockfont-8.fnt # Whether the WPS is designed to have the statusbar on or off Statusbar.320x240x16: on Statusbar.240x320x16: on Statusbar.220x176x16: on Statusbar.176x220x16: on Statusbar.176x132x16: on Statusbar.160x128x16: on Statusbar.160x128x2: on Statusbar.138x110x2: on Statusbar.128x128x16: on Statusbar.132x80x16: on Statusbar.112x64x1: on # The minimum required pixel height for the WPS # 176 for H3xx, 128 for H1xx, 64 for Recorder/Ondio, 14 for player Height.320x240x16: 240 Height.240x320x16: 320 Height.220x176x16: 176 Height.176x220x16: 220 Height.176x132x16: 132 Height.160x128x16: 128 Height.160x128x2: 128 Height.138x110x2: 110 Height.128x128x16: 128 Height.132x80x16: 80 Height.112x64x1: 64 # The minimum required pixel width for the WPS (160 for iRiver, # 220 for H3xx, 160 for H1xx, 112 for Recorder/Ondio, 55 for player Width.320x240x16: 320 Width.240x320x16: 240 Width.220x176x16: 220 Width.176x220x16: 176 Width.176x132x16: 176 Width.160x128x16: 160 Width.160x128x2: 160 Width.138x110x2: 138 Width.128x128x16: 128 Width.132x80x16: 132 Width.112x64x1: 112 I didn't know how to define the fonts for the unifont versions, but they all use the unifont font. All screenshots are in the "Screenshots" folder in the .zip file. Have read and complied with the guidelines for WPS files laid out at http://www.rockbox.org/twiki/bin/view/Main/SubmitWPS. File is over 2 mbs, so here is a direct link: http://crzyboyster.googlepages.com/Cabbie2.0DefaultRelease.zip Please comment about what you think and what needs to be updated. |
This task depends upon
Closed by Steve Bavin (pondlife)
Monday, 07 April 2008, 11:38 GMT+2
Reason for closing: Accepted
Additional comments about closing: Any bug reports can go on new entries, we have our shiny new default now!
Monday, 07 April 2008, 11:38 GMT+2
Reason for closing: Accepted
Additional comments about closing: Any bug reports can go on new entries, we have our shiny new default now!
And I've removed the screenshots, since they're not going to be commited ;)
this also needs settings_list.c to be fixed before it can go in
I've converted them all to JPEG now - but most of them are "composite" images containing views of all parts of the theme - meaning someone will have to carve them up again to get useful images for the manual out of them.
I'm looking at the settings_list stuff now.
Don't worry, though! This theme will get committed soon (within a month, I hope...)
"Don't worry, though! This theme will get committed soon (within a month, I hope...)" <- LAUGH :D
"The .cfg files will be made automatically from what someone defines in the WPSLIST file (during the build process). I'm not sure if this one is already prepared for a gradient or coloured line selector, maybe it needs some work beforehand."
Various WPSLIST options need to be available for this theme to function properly, like backdrops and icons. I would ask pixelma about all of this, though.
> wait.. why arnt the screenshots being commited? someone needs to update the manual pics.... <
There is no screenshot of the default WPS in the manual yet, but there is a chapter which explains what there is to see in words. Even if there was (or someone writes a patch for the manual related to this ;) ) - manual screenshots are png files...
> Various WPSLIST options need to be available for this theme to function properly, like backdrops and icons. I would ask pixelma about all of this, though. <
I do not know everything about it just what I could see when committing e.g. iCatcher and Rockboxed for c200; if you have a look at the mentioned entries in WPSLIST it is quite self-explanatory (I think). The biggest problem I see is that wpsbuild.pl, which generates the .cfg files from WPSLIST, is not prepared for some of the settings used here (e.g. gradient bar settings on color targets, backdrop I guess). But I also don't have an overview which settings differing from the default ones the cabbie2.0 uses exactly that's why I suggested to make a list of those to easily compare with what wpsbuild.pl provides.
Here is a quick copy and paste of the Cabbie 2.0 theme file for the ipod video which shows which settings are needed. (I think that this is what you needed...)
#Copyright 2007, Johannes Voggenthaler
#Derived from Cabbie (C) Yohann Miquitta,
wps: /.rockbox/wps/cabbie default-320x240x16.wps
font: /.rockbox/fonts/helvr12.fnt
foreground color: CCCCCC
background color: 000000
backdrop: /.rockbox/backdrops/cabbie2defaultback-320x240x16.bmp
line selector start color: fde89e
line selector end color: b58c00
selector type: bar (gradient)
iconset: /.rockbox/icons/tango_small.bmp
viewers iconset: /.rockbox/icons/tango_small_viewers.bmp
line selector text color: 000000
filetype colours: -
From what I can tell, we need the following settings identified: backdrop, line selector start, line selector end, selector type, iconset, viewers iconset, line selector text color and filetype colors (what exactly is this?).
And what is the plan for this theme to be committed? And has any progress been made on the WPSLIST thing?
The current script does not pass the Height and Width parameters to the theme cfg file. Am I supposed to be doing something with them? Do they even serve a purpose?
It also doesn't copy the backdrop file into the backdrops folder. If we're going to make this a default theme, we'll need to agree on a way to do that. Hopefully someone more central to the project has a preference for how that should be done.
I had to rename a lot of files, since they collided or didn't have names that rockbox could understand. I didn't know what to do with the unifont version, or how its different then the regular one, so I didn't include it.
To use this, just unzip the files to your WPS directory and then make a new build. I haven't tested it much, so I doubt it works fully, but its a start.
The unifont versions shouldn't include any different images than the normal versions except some ports could have an attached "U" (like wpsbackdrop-176x132x16U.bmp) and these do need to be included.
The backdrops do need to be defined somehow...
And last but not least, I have a question about renaming the theme from "cabbie default" and "cabbie unifont" to "cabbiev2". First off, was it really necessary? And another thing is that can you make it "cabbie2"? I know that this would be completely useless, but this theme is not the next version of the original Cabbie theme that "cabbiev2" implies. If this is too much work, don't bother doing it unless someone else cares.
And awesome work!
>The unifont version is simply the regular version but it just uses the font "unifont" and it definitely needs to be included.
What was the reason for using two different fonts? Regardless, we won't be able to get away with committing two identical copies of each bitmap, so I'll need to edit the build script to accommodate using the same graphics for two themes. I assume that the different versions also will have different WPS files as well?
>I tried editing the files in notepad but the wpsbuild and wpslist files just seemed corrupt...
I don't think its possible to edit any rockbox source files with notepad. Regardless I just downloaded them now and they're fine. Try using a text editor that supports unix line endings.
Metapad for example, http://www.liquidninja.com/metapad/
The unifont version was created for using different languages with ease in the default theme. And yes, the bitmaps should be the same for all versions except if a "U" is added into the unifont version one such as "wpsbackdrop-176x132x16U.bmp". And yes, they will have different wps files.
Anyway, I've committed an improved build script that allows for backdrops and the additional features needed. If you want to try it, unzip this into your rockbox source tree and create a new build.
One more thing, some of the fonts are in fnt format. We need BDF versions of the fonts since thats what the build script requires. Does anyone know where hevetica is from?
Once the fonts are taken care of, and if no one finds more bugs, I will commit the default version. Hopefully someone will have an idea for the unifont one.
P.S. It's looking like this picture, right? http://www.rockbox.org/twiki/bin/viewfile/Main/WpsSansaE200?rev=3;filename=Cabbie2WPS-AA.png
saratoga: You can probably find the helvR10 font at http://rasher.dk/rockbox/fonts/75dpi/ and it does mention at the top of the page where you can find the bdf files for them (http://webcvs.freedesktop.org/xorg/xc/fonts/bdf/75dpi/)
Having the unifont version included was considered very important when this theme was first being discussed and I think that we should do everything possible to come up with some way to have both included with seperate wps files...
And once again, great work!
/home/mike/rockbox/current/test/tools/convbdf -f -o ".rockbox/fonts/helvR10.fnt" "/home/mike/rockbox/current/test/fonts/helvR10.bdf"
Error: EOF on file
Error reading font header
any ideas?
No, that's the default (helvetica) font which looks fine. It's the unifont version that has problems with text being covered by graphics along the bottom of the WPS. Here's a screenshot of the problem: http://www.rockbox.org/twiki/bin/viewfile/Main/WpsSansaE200?rev=1;filename=cabbie2_wpsu.png
Unfortunately, while the default looks OK in the screen dumps here, it's much too small (for my eyes at least) once installed into the Sansa e200.
Here is an updated version of the whole theme so that the e200 version looks like it's supposed to. I haven't updated the complete theme with the build script and all because I'm not really sure how it functions...
And what are we going to be doing with the unifont version? Will it be committed or just put up for download separately?
If you need to make any changes to the .cfg files, please put them in WPSLIST instead. Also if you could just post the files you changed, it would make it much easier to merge them.
>And what are we going to be doing with the unifont version? Will it be committed or just put up for download separately?
I'd like to have a font that supports most languages, but I'm not sure if its worth it. Adding unifont will greatly increase download size, which I'd like to avoid. But then, I don't know how many languages are actually supported by the default font either. So for now I was going to put the default in, and then leave it to someone else who understands this stuff to figure out how to deal with unifont, then commit it when there was agreement.
I didn't make any changes to the .cfg file, just the .wps and the wps folder has some changed images, that's it.
>I'd like to have a font that supports most languages, but I'm not sure if its worth it. Adding unifont will greatly increase download size, which I'd like to avoid. But then, I don't know how many languages are actually supported by the default font either. So for now I was going to put the default in, and then leave it to someone else who understands this stuff to figure out how to deal with unifont, then commit it when there was agreement.
Personally, I think that the unifont version should be put up for download separately on the wiki so that people who want to use unifont with the default theme can just download it from there. I think that just the default version should be committed with the fonts it's using right now.
We should just commit the default version for all ports right now (just commit not make it default yet) and find all bugs, then make it the real default.
In the mean time, it'd be best if people submitted fixes as diffs against SVN, or at least as individual files if a diff is too difficult so that I can more easily apply them.
Some may say "Well dont set the font so big", but my argument is that I have excellent eye sight 20/17 and if it is too small for me it will definitely be to small for others on the e200. Perhaps the icons or the text behind them could be placed at the top or the text further up the screen as to not jumble at the bottom. Does rockbox support WPS view ports natively? Maybe the icons could be placed in a view port of their own that could fix it as well. Great job though I really do like it.
However, with viewports for wps in SVN many of such problems will fade out, since it stopps to be lane based.
Attached is an update to the e200 version. I hope I organized it properly and the only files modified are the ones included.
Is there actually a need for mix12?
Did you change all of those bitmaps or only some? I'm not sure which I should be committing.
cabbiev2.160x128x2.bmp
lockclosed-160x128x2.bmp
lockopen-160x128x2.bmp
wpsbackdrop-160x128x2.bmp
cabbiev2.160x128x2.wps
cabbie unifont-160x128x2.wps
And both of the theme files have been changed.
#define LCD_DEFAULT_BG LCD_RGBPACK(182, 198, 229) /* rockbox blue */
As far as I can tell, this patch is now ready to go, though it'd be nice if someone else tested it to make sure i'm not overlooking anything.
crzyboyster: I talked to Nico_P in IRC and he said he would handle fixing the gigabeat when he got a chance. I think he wanted to redo the backdrop.
Any obj
Edit: Theres still a problem where if you try to load Cabbie as a theme with this patch installed it breaks (though Cabbie still loads normally as the default theme). This is because of some changes to how the build script works. I'll fix it before I commit. In the meantime, it'd still be nice if people could try this on a couple targets and make sure it works fine. Grayscale would be nice too, since I don't have one of those to test on.
Personally I'd also be interested in tests on targets with remote. Unfortunately I have no remote myself but there are also sims...
Also, I committed changes to the build script to ignore color only options on grayscale targets.
Unless someone has an objection, I'll probably commit this version as is.
+#if LCD_HEIGHT <= 110
+#define DEFAULT_FONTNAME "rockfont-8"
...
won't this assign rockfont-8 to the C200 (LCD_HEIGHT = 80) and the Mini (LCD_HEIGHT = 110) cabbiev2 too? And...
if I understand correctly, checking for the right numbers will reduce the lines for all the displays that use "helvR10":
#if LCD_HEIGHT <= 64
#define DEFAULT_FONTNAME "rockfont-8"
#elif LCD_HEIGHT <= 80
#define DEFAULT_FONTNAME "Sazanami-Mincho-Regular-11"
#elif LCD_HEIGHT <= 220
#define DEFAULT_FONTNAME "helvR10"
#elif LCD_HEIGHT <= 240
#define DEFAULT_FONTNAME "helvR14"
#elif LCD_HEIGHT <= 320
#define DEFAULT_FONTNAME "helvR12"
#endif
And a minor thing about coding style which I'm really unsure of myself but haven't seen it elsewhere... so just a question: is it "allowed" or wanted to indent "#define" like that?
Anyway, default theme is now committed. I'm leaving this open for people to report bugs.
160x128 mono
lockopen-160x128x1.bmp
stop icon
all volume icons
rockbox logos both on menu and wps screen
And another thing, I tried this out on the mrobe 100 sim, but it apparently won't work. I tried to debug it, but it still won't work. Does anyone know why and fix it?
Attached
%X|wpsbackdrop-160x128x1.bmp|0|0|
The backdrop tag definitely won't work on monochrome targets. You can only use the %x tag for loading pictures statically, see the Archos or iriver remote versions for details. (And by the way the %X does not need the coordinates, maybe even doesn't allow them - %x needs them though.)
battch-160x128x1.bmp needs to be cleaned up a bit
lockopen-160x128x1.bmp needs to maybe be redone because the lock looks a bit crooked and odd...
stop-160x128x1.bmp needs to have the reflective look done better
all volume icons need to have reflections
wpsbackdrop-160x128x1.bmp needs to have a properly done monochrome rockbox logo
The bottom icons need a little breathing room (I can do this but I need the rockbox logo done and shrunk first)
I really can't do this as I can't do 1 bit design like this and make it look "good" and reflective and all.
It would be nice if I could get some opinions (here or in the forums), especially from m:robe owners because sometimes it looks quite different on the target's display.
The attached zip has the right folder structure but only the .wps file (not the cfg), so you can just unzip it to the device and chose it from the "browse wps files"; the font should be set to helvR10 which is already the default font for the m:robe100, in case you use a different one currently.
Oh, and I'd like to commit it tomorrow if there are no objections (probably in about 12 hours).
The vol-0x ones shouldn't be there (they are yours) only the ones without the 0 as this is what the majority of the other cabbiev2 ports use. Sorry, I messed it up in the zip.
About vol-9: the conditional should be used as <mute icon|..|..|0db icon|over 0dB icon> - in my opinion the 0dB should be the "full" one without the exclamation mark which only ever shows up at 0dB (and it does it correctly) and the "over 0dB" a full one with exclamation mark to show one should expect clipping. This is done this way in the colour versions by the way (which is why the 160x128x16 version has a vol-9 icon) but not done in the greyscale version: someone asked today why the volume indicator never reaches "full" on the H100 which can only get as loud as 0dB, so only vol-7 is shown as last state...
About the display inverted, it's hard to explain but - yes black is white (or rather red with the backlight) on display and white is black. So if you draw the original icons black with a white spot on the "upper" side and you now imagine that inverted you'll get a white icon which has a dark spot on the "upper" which will then make it look sunken because the human mind expects the "light" coming from the above (and slighty left). Just inverting would be a solution for the 3D problem but then the icon will be mostly dark maybe with a bright outline but it's not that visible - and I thought cabbiev2 icons are about bright icons on dark background which are raised. (hopefully the attached mockup can explain - I prefer the last version which is what I did).
I can't understand completely what you mean with pixelated, of course they are a bit because there is no possibility to anti-alias them. Making them more line-art like you did could be a solution too but it looks too simple to me (the greyscale ones too, by the way). I wanted to still give the impression of 3D and make them more like the original ones - and you said yourself that yours don't look reflective enough... I understand that this is also a question of taste... I also tried to have a sort of "gradient" effect with the dotted lines because to me it looked better on my monitor and how present that pixelation is depends on the actual pixel size (of your monitor, the m:robe100's display...). I could imagine to drop that but to me it looked better (but this is also one reason I put it up for discussion here).
P.S.: I also attach a new zip with only one set of volume icons.
Also, just making the images negative doesn't quite work - assuming the light comes from the top, a dark bar will get a highlight at the top, whereas a bright bar will get a shadow at the bottom. You can see that effect in the picture pixelma attached 3 posts above: http://www.rockbox.org/tracker/task/8443?getfile=16130
What I am trying to express is that if the "choppiness" was removed and a real 3D effect was given to certain icons, it would look a lot better. Like in the attached bitmap, the white pixels will simply be random dots spread throughout the place looking unprofessional. We should put in a real 3D effect. (And did you just convert the images from original 16 or 24 bit straight to mono and clean them up a bit?)
I did not convert and cleaned up later, but drew them completely new (next to the colour ones to get the size right), and I tried a lot with slight variations. I would say I set every pixel deliberately (took me a few hours yesterday and today, you could say a working day). To me the form factor is pretty good, the "shading" could be discussed but I'm not sure how it could be vastly improved if you want to keep it (and I would want).
Your screendumps don't show the real thing - look at a current simulator which also simulates the "inverse" LCD. It does not show in a "F5" screendump yet so I took the screenshot with the feature of my PC operating system and cropped it later. And I just realised that this could be the reason you think the graphics are choppy in the lower right corner(s)? This should mark the shadow a bit and in the thin line of the repeatall arrows you can't do much more than deleting a few pixels, otherwise you cut the outline. And it really looks differently if you look at it "inverted" and in the colours of the m:robe100's display which are now simulated...
In any case, this is just a start and of course can be changed later if someone has a better solution. I am of course open to suggestions even if this discussion might make it sound different - it's just that my impression was that the problem wasn't understood and I couldn't imagine what should be done and where and how. Maybe a better place for real discussion would be the forums or IRC.
Edit: attach the files...
I positioned the original right in the corner to minimize any overlap with long menu entries, and to be consistent with the position of other elements like the default status bar, which places the battery level icon up against the left edge of the screen area... it's not a big deal though :-)
Now made new greyscale WPS graphics too and put them up for discussion here (including screenshots). I tried to find a version somewhere between the current greyscale one (I liked the progress and now playing bar, for example) and the colour one. The size of the icons is slightly bigger than the colour icons but I think they represent the style quite good this way and have enough "weight" on this screen. Attached are screenshots and wps.zip for the 138x110 (Mini) and the 160x128 greyscale displays (H100, M5, rest of the greyscale Ipods). The zip is in the right directory structure, so just unzzp to the player - but it'll overwrite any current cabbie things (because it's taken from compiled simulators). It also contains the new backdrop picture.
And task 4885 would also be very beneficial to the unicode versions so that the unicode downloads will not have to be constantly updated every time images are changed (also less file size for zips)
> http://www.rockbox.org/tracker/task/4885
As far as I can tell, pixelma has finished with her changes to this theme.