Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8572 - USLT lyric viewer

Attached to Project: Rockbox
Opened by Lechner Michael (smoking_gnu) - Saturday, 09 February 2008, 20:36 GMT+2
Task Type Patches
Category ID3 / meta data
Status Unconfirmed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This viewer reads the USLT lyrics from a mp3 file and displays them using a gui_list.
You have to select "open with.." on a mp3 file in the file browser to show the lyrics.
I tested it on the sim and on my X5.


   lyric_viewer.patch (5.9 KiB)
This task depends upon

Comment by Lechner Michael (smoking_gnu) - Monday, 11 February 2008, 21:57 GMT+2
Small update: now it reads the length of the ID3 tag before it starts searching for the lyric tag;
If there's no lyric tag in the file it now doesn't take age anymore till my plugin realizes it ;)
Also a few minor bugfixes and code cleanup.

   lyric2.patch (6.6 KiB)
Comment by Pascal Briehl (ColdSphinX) - Tuesday, 12 February 2008, 06:26 GMT+2
this could probably merged with the sncviewer plugin
http://www.rockbox.org/tracker/task/7432
Comment by Vuong Minh Hiep (vmh) - Tuesday, 12 February 2008, 15:55 GMT+2
I added USLT support to the sncviewer back in November 2007 due to some requests, but the plugin wasn't intended for unsynchronized lyrics.
I think it's better to have two different plugins, one for synchronized (sncviewer) and one for unsynchronized lyrics (this one).
Comment by Lechner Michael (smoking_gnu) - Wednesday, 13 February 2008, 12:21 GMT+2
I wrote this plugin for 2 reasons:
1. I thought the sncviewer plugin did NOT support USLT lyrics
2. I wanted to start coding for rockbox anyway.
Comment by George Tamplaru (kratonator) - Sunday, 17 February 2008, 12:40 GMT+2
I am not able to apply this patch. I get (for -p0 to -p5) the following message:

missing header for unified diff at line 5 of patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: CATEGORIES
|=================================================
|--- CATEGORIES (revision 16229)
|+++ CATEGORIES (working copy)
--------------------------
File to patch:

What am I doing wrong?
Comment by Lechner Michael (smoking_gnu) - Sunday, 17 February 2008, 23:36 GMT+2
I did not use ANY -p or --strip option...
The patch works for me...
However I made a new one from the current SVN for you:
   lyric_viewer.diff (6.8 KiB)
Comment by Przemysław Hołubowski (p.h.) - Friday, 11 April 2008, 13:44 GMT+2
Could you adopt it to the new plugin API? (It does not work with recent builds).
Comment by Lechner Michael (smoking_gnu) - Saturday, 12 April 2008, 22:13 GMT+2
Sorry, but I can't compile right now. I'll have a look at it on monday.
Comment by Lechner Michael (smoking_gnu) - Wednesday, 16 April 2008, 20:39 GMT+2
Here's a new, working version (viewports broke the old one) :
   lyric_viewer.c (5.5 KiB)

Loading...