Rockbox

Tasklist

FS#8585 - jpeg_viewer: fit lcd

Attached to Project: Rockbox
Opened by x (vmh) - Sunday, 10 February 2008, 18:08 GMT
Last edited by Peter D'Hoye (petur) - Sunday, 24 February 2008, 23:09 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

find optimal scale factor for the image to fit LCD as initial scale factor
This task depends upon

Closed by  Peter D'Hoye (petur)
Sunday, 24 February 2008, 23:09 GMT
Reason for closing:  Rejected
Additional comments about closing:  this is not how we want the viewer to behave, sorry...
Comment by Peter D'Hoye (petur) - Monday, 11 February 2008, 22:11 GMT
What does this fix? max_downscale() does what your code does, so your code will always result in selecting ds_max.

Comment by x (vmh) - Tuesday, 12 February 2008, 08:39 GMT
> max_downscale() does what your code does
No, not exactly the same. If you compare both code you'll notice max_downscale() uses 'or' and mine uses 'and'. That means in max_downscale(), both width AND hight, must be smaller than the LCD, but in my code however it's sufficient if only height OR width is smaller than the LCD.

> so your code will always result in selecting ds_max
No, not always. It depends on your LCD size and the picture size.
To test it you have to use pictures of different sizes.
Comment by Peter D'Hoye (petur) - Friday, 15 February 2008, 08:54 GMT
To be honest, I couldn't find a picture where your code change made a difference, unless I'm doing something wrong...
Comment by x (vmh) - Sunday, 24 February 2008, 20:12 GMT
@petur: Try with these picture. Hope you'll see a difference.
Comment by Peter D'Hoye (petur) - Sunday, 24 February 2008, 22:56 GMT
ok, I see the difference now, and I think I like current behaviour better than your patch: With your patch, these pictures show up partially zoomed, where SVN shows the complete picture...

Loading...