Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8602 - Remove audiohw_set_lineout_vol call from sound.c

Attached to Project: Rockbox
Opened by Christian Gmeiner (ChristianGmeiner) - Tuesday, 12 February 2008, 19:12 GMT+2
Task Type Patches
Category Drivers
Status Unconfirmed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Hi all.

I have found a funny thing, which should get fixed. In set_prescaled_volume there is this call:
audiohw_set_lineout_vol(tenthdb2master(0), tenthdb2master(0));

As far as I can see this call is not needed here. So this patch removes it, but as I own only a sansa e280 I can not test this change. I hope to commit this soon.

If this call is needed... do we need it every time audio changes or only once at init?

Thanks,
AustrianCOder
   remove_call_to_audiohw_set_li... (0.6 KiB)
This task depends upon

Comment by Thom Johansen (preglow) - Tuesday, 12 February 2008, 21:15 GMT+2
This call sets the line out volume to 0 dB always, which is how line outs usually works. It doesn't need to be set in every set_prescaled_volume(), but it should be set some time during init, at least.
Comment by Christian Gmeiner (ChristianGmeiner) - Tuesday, 12 February 2008, 21:55 GMT+2
Okay.. this is my second try.
I make now use of audiohw_postinit to set lineout volume. Maybe we should check datasheet if we
need to set linout volume - maybe default value is okay?
   remove_call_to_audiohw_set_li... (5.3 KiB)
Comment by Robert Kukla (roolku) - Tuesday, 12 February 2008, 23:59 GMT+2
Since you now call audiohw_set_lineout_vol() from the audio codec specific files you could work out the values and registers and set them directly
Comment by Thom Johansen (preglow) - Wednesday, 13 February 2008, 12:09 GMT+2
The closest corresponding datasheet to wm8758 indicates 0 dB is the default, but I can't be bothered to check the others. Since these data sheets aren't exact matches, we'd need to verify with owners of the devices what the actual defaults are anyway.
Comment by Christian Gmeiner (ChristianGmeiner) - Wednesday, 13 February 2008, 13:02 GMT+2
I did a quick internet research and found this:

- wm8751 - http://www.wolfsonmicro.com/uploads/documents/en/WM8751.pdf --> 0db default -> see page 26
for wm8975 and wm8758 I found no datasheet. But I think that they have all 0db as default.

Loading...