Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8607 - MPEG video playlist

Attached to Project: Rockbox
Opened by Andree Boeger (Candy) - Thursday, 14 February 2008, 09:50 GMT+2
Last edited by Teruaki Kawashima (teru) - Friday, 26 November 2010, 13:49 GMT+2
Task Type Patches
Category Video
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

If play mode = file, mpegplayer plays a video and stops at the end of the video, returning to the file browser (as it is the state now). In case of play mode = directory mpegplayer assumes a playlist which is identical to the current directory (lexically order of the files). This is the same behaviour, as if rockbox plays an audio file selected from the file browser. The playback stops when the last file in the directory has been played.

Having this playlist, you can easyly skip to the next or the previous video file by pressing the FF or RW button shortly.

It makes sense to switch the resume option to "Play from beginning", if you want to watch one video after another, but it's not neccessary.
   mpegplayer_playlist.patch (13.3 KiB) 
 rockbox-20080213patch/apps/plugins/mpegplayer/mpegplayer.c    |  265 ++++++++--
 rockbox-20080213patch/apps/plugins/mpegplayer/mpeg_settings.c |   16 
 rockbox-20080213patch/apps/plugins/mpegplayer/mpeg_settings.h |    2 
 3 files changed, 241 insertions(+), 42 deletions(-)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Friday, 26 November 2010, 13:49 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r28667
Comment by Robert Kukla (roolku) - Monday, 18 February 2008, 17:24 GMT+2
I find this quite useful - as long as there are only few files in the directory and the skip is infrequent I think the approach is sensible (as opposed to maintaining a playlist like in the jpg viewer). The skip order is the order files are stored in the directory which is not neccessary alphabetically for FAT.
Comment by Michael Sevakis (MikeS) - Saturday, 17 May 2008, 21:57 GMT+2
I think implementing as an engine control layer would be the proper approach - not in the UI layer. Additionally, a full stream_init should _not_ be needed between files but just a stream_close/stream_open. It is designed that way in anticipation of this sort of feature.
Comment by Michael Sevakis (MikeS) - Saturday, 17 May 2008, 22:20 GMT+2
I should mention that I tried to apply this patch to SVN r17557 without success so I could have misread some aspects of the .diff.
Comment by Taylore (trailblaze) - Sunday, 21 December 2008, 16:55 GMT+2
hmm... This patch looks really kool, however i got lots'o' hunk errors also... Can someone with patch experience fix this please.?
Comment by Jacob Brooks (jac0b) - Monday, 12 January 2009, 22:16 GMT+2
Resync
   mpegplayer_playlist-090112.patch (13.1 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c    |  264 ++++++++++++++++++++++++++------
 apps/plugins/mpegplayer/mpeg_settings.c |   16 +
 apps/plugins/mpegplayer/mpeg_settings.h |    2 
 3 files changed, 240 insertions(+), 42 deletions(-)

Comment by Taylore (trailblaze) - Friday, 16 January 2009, 22:56 GMT+2
lol. Thank you for resyncing it. It worked very nicely!, while it did.. I guess it it broken again,,, since i got a Hunk #10 fail at 1892 in apps/plugins/mpegplayer/mpegplayer.c (on build 19778)... Hmphh.. would you mind re-resyncing it please? thank you in advance...
Comment by Jacob Brooks (jac0b) - Saturday, 17 January 2009, 17:42 GMT+2
Resync
   mpegplayer_playlist-090117.patch (13.1 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c    |  264 ++++++++++++++++++++++++++------
 apps/plugins/mpegplayer/mpeg_settings.c |   16 +
 apps/plugins/mpegplayer/mpeg_settings.h |    2 
 3 files changed, 240 insertions(+), 42 deletions(-)

Comment by Jacob Brooks (jac0b) - Saturday, 18 April 2009, 18:25 GMT+2
Resync
   mpegplayer_playlist-090418.patch (13.2 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c    |  262 ++++++++++++++++++++++++++------
 apps/plugins/mpegplayer/mpeg_settings.c |   16 +
 apps/plugins/mpegplayer/mpeg_settings.h |    2 
 3 files changed, 239 insertions(+), 41 deletions(-)

Comment by Taylore (trailblaze) - Sunday, 21 June 2009, 21:55 GMT+2
hmm.. It seems to be broken again.. One hunk error while patching.. May someone please sync this again please?
Comment by Jacob Brooks (jac0b) - Friday, 24 July 2009, 01:40 GMT+2
I tried to figure it out but they have rewritten the api so it is pretty well mangled. This is where the change happened
http://svn.rockbox.org/viewvc.cgi/trunk/apps/plugins/mpegplayer/mpeg_settings.c?r1=21305;r2=21306;pathrev=21306
Comment by Teruaki Kawashima (teru) - Friday, 28 August 2009, 14:08 GMT+2
resync and change.
* short press of button for rewinding starts current video from the beginning if postition is not near the beginning regardless the resume option.
   mpegplayer_playlist-090828.patch (13 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c    |  252 ++++++++++++++++++++++++++------
 apps/plugins/mpegplayer/mpeg_settings.c |   16 +-
 apps/plugins/mpegplayer/mpeg_settings.h |    2 
 3 files changed, 229 insertions(+), 41 deletions(-)

Comment by Teruaki Kawashima (teru) - Wednesday, 13 January 2010, 14:29 GMT+2
Update patch.
* Don't change video by pressing left or right button if in single mode.
* Add item to change video to menu.
* don't do stream_init and stream_exit when change video. don't know if it is done correctly.
   mpegplayer_playlist-100113.patch (11.3 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c    |  151 ++++++++++++++++++++++++++++++--
 apps/plugins/mpegplayer/mpeg_settings.c |   24 +++--
 apps/plugins/mpegplayer/mpeg_settings.h |    4 
 apps/plugins/mpegplayer/mpeg_parser.c   |    1 
 apps/plugins/mpegplayer/video_thread.c  |    6 +
 5 files changed, 171 insertions(+), 15 deletions(-)

Comment by Teruaki Kawashima (teru) - Friday, 18 June 2010, 16:47 GMT+2
synced to r26919.
   mpegplayer-palylist-r26919.patch (11.4 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c    |  151 ++++++++++++++++++++++++++++++--
 apps/plugins/mpegplayer/mpeg_settings.c |   24 +++--
 apps/plugins/mpegplayer/mpeg_settings.h |    4 
 apps/plugins/mpegplayer/mpeg_parser.c   |    1 
 apps/plugins/mpegplayer/video_thread.c  |    6 +
 5 files changed, 171 insertions(+), 15 deletions(-)

Comment by Teruaki Kawashima (teru) - Monday, 01 November 2010, 16:11 GMT+2
update patch.
   mpegplayer-palylist-r28430.patch (10.4 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c    |  141 +++++++++++++++++++++++++++++---
 apps/plugins/mpegplayer/mpeg_settings.c |   14 ++-
 apps/plugins/mpegplayer/mpeg_settings.h |    2 
 apps/plugins/mpegplayer/mpeg_parser.c   |    1 
 apps/plugins/mpegplayer/video_thread.c  |    6 +
 5 files changed, 153 insertions(+), 11 deletions(-)

Loading...