Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8607 - MPEG video playlist

Attached to Project: Rockbox
Opened by Andree Boeger (Candy) - Thursday, 14 February 2008, 09:50 GMT+2
Last edited by Marc Guay (Marc_Guay) - Thursday, 10 April 2008, 01:56 GMT+2
Task Type Patches
Category Video
Status Unconfirmed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

If play mode = file, mpegplayer plays a video and stops at the end of the video, returning to the file browser (as it is the state now). In case of play mode = directory mpegplayer assumes a playlist which is identical to the current directory (lexically order of the files). This is the same behaviour, as if rockbox plays an audio file selected from the file browser. The playback stops when the last file in the directory has been played.

Having this playlist, you can easyly skip to the next or the previous video file by pressing the FF or RW button shortly.

It makes sense to switch the resume option to "Play from beginning", if you want to watch one video after another, but it's not neccessary.
   mpegplayer_playlist.patch (13.3 KiB)
This task depends upon

Comment by Robert Kukla (roolku) - Monday, 18 February 2008, 17:24 GMT+2
I find this quite useful - as long as there are only few files in the directory and the skip is infrequent I think the approach is sensible (as opposed to maintaining a playlist like in the jpg viewer). The skip order is the order files are stored in the directory which is not neccessary alphabetically for FAT.
Comment by Michael Sevakis (MikeS) - Saturday, 17 May 2008, 21:57 GMT+2
I think implementing as an engine control layer would be the proper approach - not in the UI layer. Additionally, a full stream_init should _not_ be needed between files but just a stream_close/stream_open. It is designed that way in anticipation of this sort of feature.
Comment by Michael Sevakis (MikeS) - Saturday, 17 May 2008, 22:20 GMT+2
I should mention that I tried to apply this patch to SVN r17557 without success so I could have misread some aspects of the .diff.

Loading...