Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8611 - Move hw_info to target tree (pp)

Attached to Project: Rockbox
Opened by Christian Gmeiner (ChristianGmeiner) - Saturday, 16 February 2008, 17:46 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Sunday, 05 June 2011, 13:26 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch moves hw_info stuff for PortalPlayer out of /apps and moves it into target tree.

Please review,
Christian
   move_pp_hw_info_to_target_tree.patch (11 KiB) 
 apps/debug_menu.c                  |  103 --------------------------------
 firmware/SOURCES                   |   14 ++++
 firmware/target/arm/debug-pp.c     |  119 +++++++++++++++++++++++++++++++++++++
 firmware/target/arm/debug-target.h |   21 ++++++
 4 files changed, 155 insertions(+), 102 deletions(-)

This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Sunday, 05 June 2011, 13:26 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Parts of debug screen are in target tree currently.
Comment by Christian Gmeiner (ChristianGmeiner) - Saturday, 16 February 2008, 17:48 GMT+2
Upps.. try #2
   move_pp_hw_info_to_target_tree_try2.patch (10.9 KiB) 
 apps/debug_menu.c                  |  103 ---------------------------------
 firmware/SOURCES                   |   14 ++++
 firmware/target/arm/debug-pp.c     |  113 +++++++++++++++++++++++++++++++++++++
 firmware/target/arm/debug-target.h |   21 ++++++
 4 files changed, 149 insertions(+), 102 deletions(-)

Comment by Daniel Stenberg (bagder) - Saturday, 16 February 2008, 18:04 GMT+2
I don't like how you nick the copyright of the code by this move. The new files you create should have the same copyright of the source of this copy.
Comment by Christian Gmeiner (ChristianGmeiner) - Saturday, 16 February 2008, 18:18 GMT+2
No problem :)

Here is try #3 - I am allowed to commit it?
Comment by Christian Gmeiner (ChristianGmeiner) - Saturday, 16 February 2008, 18:18 GMT+2
missed patch
   move_pp_hw_info_to_target_tree_try3.patch (10.9 KiB) 
 apps/debug_menu.c                  |  103 ---------------------------------
 firmware/SOURCES                   |   14 ++++
 firmware/target/arm/debug-pp.c     |  113 +++++++++++++++++++++++++++++++++++++
 firmware/target/arm/debug-target.h |   21 ++++++
 4 files changed, 149 insertions(+), 102 deletions(-)

Comment by Kévin Ferrare (TiMiD) - Sunday, 20 July 2008, 05:40 GMT+2
A better idea would be to split the code in two parts :
- the functions who retrieve the hardware infos in the target tree
- the code which interracts with ths user apps/
That would modularize and clarify the code besides the fact that the code in firmware/ cannot use the advanced display features like viewports and multiscreen

Loading...