Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8630 - make sleep timer value persistent

Attached to Project: Rockbox
Opened by x (vmh) - Saturday, 23 February 2008, 01:58 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Sunday, 05 June 2011, 13:02 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes the sleep timer value persistent, so the user doesn't have to adjust the sleep timer every time.
   sleep_timer.patch (3.9 KiB) 
 apps/settings.h          |    1 +
 apps/settings_list.c     |   23 +++++++++++++++++++++++
 apps/menus/main_menu.c   |   35 ++---------------------------------
 apps/gui/option_select.c |    2 +-
 4 files changed, 27 insertions(+), 34 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Sunday, 05 June 2011, 13:02 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  no real name
Comment by x (vmh) - Saturday, 23 February 2008, 08:35 GMT+2
There's a bug in this patch, which will always start the sleep timer when the user is entering the sleep timer setting. I think the best solution is to add an additional parameter to the callback, so the callback can decide what to do on which action (button press). But the effect is that many other files need to be updated (adding the action parameter). Does someone see a better solution?
   sleep_timer.patch (3.5 KiB) 
 apps/settings.h        |    1 +
 apps/settings_list.c   |   23 +++++++++++++++++++++++
 apps/menus/main_menu.c |   35 ++---------------------------------
 3 files changed, 26 insertions(+), 33 deletions(-)

Comment by x (vmh) - Sunday, 22 June 2008, 23:12 GMT+2
synchronized to r17755
   sleep_timer.patch (3.8 KiB) 
 apps/settings.h        |    1 +
 apps/settings_list.c   |   24 ++++++++++++++++++++++++
 apps/menus/main_menu.c |   35 ++---------------------------------
 3 files changed, 27 insertions(+), 33 deletions(-)

Comment by alex wallis (alexwallis646) - Monday, 23 June 2008, 00:43 GMT+2
Hi thanks for the resync.
Comment by Taylore (trailblaze) - Tuesday, 24 March 2009, 23:11 GMT+2
hmph.. out of sync again, may someone please resync it please... This is a good idea, and would be kool 2 use, since i hate keeping on resetting the sleep timer..
Comment by alex wallis (alexwallis646) - Wednesday, 25 March 2009, 00:41 GMT+2
I agree with the above, I asked about getting this committed on the rb dev list, but for some reason people didn't seem keen I am not sure why. As I think it is a good idea as well.
Comment by alex wallis (alexwallis646) - Thursday, 09 July 2009, 18:27 GMT+2
Hi. Any chance of getting this resynced please?

Loading...