Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Games
  • Assigned To
    kkurbjun
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Demonic_Fate - 2008-02-25
Last edited by fg - 2008-09-08

FS#8641 - Doom 90 degree rotate crash

On my Sansa e260 i want to run doom in the “Rotate screen 90 degrees” mode and i put turn it on, and start doom(all dooms do the same i’ve got 1 and 2),i do new game, and im playing for about… i think 8 seconds and then it give me “Undefined Instruction at 40001DCC (0)”. BUT, if i run doom without the 90 degree rotation.. i can play for hours on end. Is there a fix? do i need an older version? Plz help. :(

Closed by  fg
2008-09-08 15:18
Reason for closing:  Accepted

Likely related to (aka duplicate of)  FS#8629 , isn’t it?

No, he said “hitting the power button at the Freedoom splash Screen.” was bring that I have no problem with hitting the power button at any time, its the same bug error messege but not the same reason it crashes.. I only crash with 90 degree flip.

No, he said “hitting the power button at the Freedoom splash Screen.” That, I have no problem with, its the same bug error messege but not the same reason it crashes.. I only crash with 90 degree flip and nothing else will crash it.

i Got the new daily update from today and now i get “Data Abort at 0004 BCD8 (0)” with doom using 90 degree flip

I have the same problem on a Gigabeat F with the error “Undefined instruction as 0237C56C”

MikeS commented on 2008-03-19 21:25

Just a quick guess but I think in i_video.c:

1) Line 607 should be

  for (y = 1; y <= SCREENHEIGHT; y++)

2) Or line 609 in i_video.c should be

  fb_data *dst = rb->lcd_framebuffer + LCD_WIDTH - y - 1;

Pick either one but 1) is more efficient.

Nope that doesn’t fix it. It didn’t take down the house with a memory error but it still crashed back to Rockbox. To top it off the menu screen ended up shifted left afterwards as well. I’m going to keep trying to figure it out, playing doom scaled wrong is just, well, wrong… :)

I don’t think it’s in that chunk of code, if it was then it should either a) display incorrectly or b) crash right away. Problem is that it crashes after a while,not right away.

I have just modified my i_video.c and modified it with the first suggestion. Tested both original build and build with the change. Original build always crashes. It seems to have worked. I’ve been playing with the screen rotated for awhile now. Should I post a patch?

Sure!

Please let me know if this patch works. I’m very new at this.

Please let me know if this patch works. I’m very new at this.

MikeS commented on 2008-05-17 18:18

Actually that will only draw 239 lines, it needs to be “⇐ SCREENHEIGHT” as per 1).

Looks fine to me on a sansa e200. I’ll test it with ⇐ in a few moments.

New patch with the correct fix. Will this fix or break anything on other targets?

I don’t think so.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing