Rockbox

Tasklist

FS#8644 - Make Rockbox work with CF modded devices

Attached to Project: Rockbox
Opened by Peter D'Hoye (petur) - Monday, 25 February 2008, 22:47 GMT
Last edited by Peter D'Hoye (petur) - Sunday, 09 March 2008, 13:25 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Proposal to make rockbox work on targets with CF cards (modded)
Assumes identify[0] == 0x044A as CF detection
Also changes some minor stuff that I think was wrong.

The important change for CF:
- don't set powermanagement
- don't perform perform_soft_reset()
   CF.patch (4.3 KiB)
This task depends upon

Closed by  Peter D'Hoye (petur)
Sunday, 09 March 2008, 13:25 GMT
Reason for closing:  Accepted
Additional comments about closing:  committed!
Comment by Frank Otto (magmaniac) - Tuesday, 26 February 2008, 12:13 GMT
At the moment, the identify[0]==0x044A check appears twice. I would propose to factor out this "CF detection" into a function (maybe inlined) or a macro, for better maintainability.

Comment by Peter D'Hoye (petur) - Tuesday, 26 February 2008, 12:29 GMT
yes, the thought has crossed my mind too (after posting the patch). Would allow to change it into a list, and possibly check once + remember
Comment by Frank Otto (magmaniac) - Tuesday, 26 February 2008, 20:17 GMT
For reference, here are the values for identify[0] that we collected for various cards/disks in IRC on 2008-02-22:

044A - CF Transcend 133x 2GB (magmaniac)
044A - CF A-Data 266x 8GB (petur)
044A - iPod nano (amiconn)
0040 - HD MK8007GAH, iriver H180 (amiconn)
0040 - HD MK2004GAL, iriver H120 (magmaniac)
0C5A - HD ST660211, iriver H10 (amiconn)
848A - MicroDrive HMS360604D5CF00, iPod mini (amiconn)

Of course it'd be great if we had more data...
Comment by Peter D'Hoye (petur) - Wednesday, 27 February 2008, 20:05 GMT
adapted, also added a line containing identify[0] to disk info in the debug menu
Comment by Peter D'Hoye (petur) - Wednesday, 27 February 2008, 23:01 GMT
committed the original dump_identify from amiconn, so undo my debug_menu tweak
Comment by Peter D'Hoye (petur) - Saturday, 01 March 2008, 16:10 GMT
new CF detection thanks to amiconn. To be tested if this influences power consumption on the H10 5GB, as its microdrive also reports itself as CF
Comment by Peter D'Hoye (petur) - Monday, 03 March 2008, 22:31 GMT
and another one...
thanks to amiconn, we figured out that on soft_reset(), the card actually does a hard reset. So we need to reconfigure after soft_reset

Please test if this one is also stable (no freezing). Also to be tested on ipod nano.
Comment by Peter D'Hoye (petur) - Tuesday, 04 March 2008, 22:12 GMT
some cleanup
Comment by Peter D'Hoye (petur) - Thursday, 06 March 2008, 08:21 GMT
I'm doing battery benchmarks on H10 5GB, it would be nice if somebody could test this on ipod nano
Comment by Peter D'Hoye (petur) - Friday, 07 March 2008, 00:57 GMT
another day, another patch

getting close to committing, this patch only uses power management bits to set power management, no more CF detection.

please test.....
Comment by Peter D'Hoye (petur) - Saturday, 08 March 2008, 15:18 GMT
CF7 was no good...

this is a more simple take on the issue (I give up on getting it to work in a nice way)

Loading...