Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8690 - Keyboard switching for plugin

Attached to Project: Rockbox
Opened by Takoyaki Sato (taksato) - Thursday, 06 March 2008, 13:17 GMT+2
Last edited by Alex Parker (BigBambi) - Sunday, 06 June 2010, 13:03 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is a change about loading keyboard across plugins. A VTable entry is added to the end of the plugin structure, so it can be call the load_kbd function across a dynamic plugin.

I test this on a Sansa, but it is workable to all.

* Notice: This won't store or replace your keyboard setting based on what you do in plugin when alone call the load_kbd from plugin.

- Tak
   keybdchanges.patch (0.8 KiB) 
 rockbox/apps/plugin.c |    3 +++
 rockbox/apps/plugin.h |    3 +++
 2 files changed, 6 insertions(+)

This task depends upon

Closed by  Alex Parker (BigBambi)
Sunday, 06 June 2010, 13:03 GMT+2
Reason for closing:  Out of Date
Comment by Takoyaki Sato (taksato) - Thursday, 06 March 2008, 15:30 GMT+2
Apologies, I had forgot one detail about the plugin api version. Only used: PLUGIN_API_VERSION, because I left it dangling at the end waiting for anyone to change an existing API to sort near a kbd routine. Please consider to integrate this one.
   keybdchanges2.patch (1.1 KiB) 
 rockbox/apps/plugin.c |    3 +++
 rockbox/apps/plugin.h |    5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

Comment by Peter D'Hoye (petur) - Monday, 10 March 2008, 22:22 GMT+2
I don't understand this patch. It just adds the vkeyboard function to the API, but it is not used?
Comment by Takoyaki Sato (taksato) - Tuesday, 01 April 2008, 05:26 GMT+2
Yes, it is currently unused. I am porting a GPL App from the sourceforge that can take usage of the function. This looked like a smaller change that might have some use to some quickly, so I put it independent. My development porting is slow for a busy spring season in my current job. The task at hand is a stardict port fwiw. I hope someone can take the plugin vtable update. Happy hanami season to you and yours!

Loading...