Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8708 - Cowon D2: Button definitions for plugins and WPS

Attached to Project: Rockbox
Opened by Andreas Müller (andiator) - Sunday, 09 March 2008, 21:13 GMT+2
Last edited by Rob Purchase (shotofadds) - Sunday, 27 April 2008, 18:35 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player type Another
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Cowon D2: Key/Button definitions/mappings for plugins, WPS and setings menu. Alot of '#define' stuff
   d2-button-mapings.patch (38.5 KiB)
This task depends upon

Closed by  Rob Purchase (shotofadds)
Sunday, 27 April 2008, 18:35 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks :-)
Comment by Rob Purchase (shotofadds) - Saturday, 19 April 2008, 14:39 GMT+2
I've re-opened this task since many of the button definitions need to be altered to use the "touchscreen area" button macros (see button-target.h) rather than the existing BUTTON_LEFT/RIGHT etc. Eg. BUTTON_UP becomes BUTTON_TOPMIDDLE, BUTTON_RIGHT becomes BUTTON_MIDRIGHT, etc.

The touchscreen button definitions should be defined in a HAVE_TOUCHPAD block (common to the D2 and m:robe500), with the D2-specific section containing only definitions for the physcial buttons (PLUS/MINUS/MENU/POWER).
Comment by Rob Purchase (shotofadds) - Sunday, 20 April 2008, 22:05 GMT+2
I should have mentioned that the current SVN build only supports the touchscreen area buttons (BUTTON_TOPMIDDLE etc) when running in the UI Simulator (mapped to keypad keys 1-9).

The attached patch adds touchpad support to the target build, by adapting JdGordon's existing m:robe500 work. It's far from perfect, for example menu navigation is difficult because it sometimes registers incorrect presses. But it does make plugins such as jewels and brickmania playable ;-)
   d2-touchpad-v1.diff (6.9 KiB)
Comment by Rob Purchase (shotofadds) - Monday, 21 April 2008, 10:08 GMT+2
Sync'd to r17200 by correcting an idiotic typo or two.
   d2-touchpad-v2.diff (7.1 KiB)
Comment by Andreas Müller (andiator) - Wednesday, 23 April 2008, 22:53 GMT+2
So, there a lot of changes. Almost all plugins got a touchpad section. Some have only one button (exit or so) - so I let it the way it was.
Other touchpad-targets have to define a target section anyway, at least an empty one.
The touchpad definitions are overrideable: e.g. #define PLUGIN_EXIT POWER_BUTTON in target section overrides the one in touchpad section (made with #ifndef PLUGIN_EXIT ...)

Added some missing button description/help text for some plugins. Had to change #ifdef/#else logic in plasma.c and starfield.c, hoping not to break other targets.
Changed drivers/button.c, there was an assumption that every target has BUTTON_LEFT/BUTTON_RIGHT --> added a mapping from BUTTON_MIDLEFT to BUTTON_LEFT etc. Is needed for screen flipping.
   d2+touchpad_button_mapping.pa... (74.4 KiB)
Comment by Andreas Müller (andiator) - Sunday, 27 April 2008, 13:57 GMT+2
Update for r17254 (New plugin flashlight.c)
   d2+touchpad_button_mapping.pa... (75.3 KiB)
Comment by Andreas Müller (andiator) - Sunday, 27 April 2008, 16:30 GMT+2
Got brickmania working
   d2_tchpd_bttn_mapping_v3.patch (74.5 KiB)

Loading...