Rockbox

Tasklist

FS#8717 - Several System->Debug Menu Items Don't Revert to the User Interface Font on Exit

Attached to Project: Rockbox
Opened by Marc Guay (Marc_Guay) - Tuesday, 11 March 2008, 03:22 GMT
Last edited by Marc Guay (Marc_Guay) - Thursday, 27 March 2008, 00:23 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The following entries in the Debug Menu:

View I/O
CPU Freq.
View Batt.
View HW Info
View Buff Thread

are missing the command "lcd_setfont(FONT_UI)" (I think) on exit, but I'm not familiar enough with the code to know where it should be or even if that's the right function. Basically the same issue as this: http://www.rockbox.org/tracker/task/8701.

Sansa e200 + r16601
This task depends upon

Closed by  Marc Guay (Marc_Guay)
Thursday, 27 March 2008, 00:23 GMT
Reason for closing:  Fixed
Comment by Marc Guay (Marc_Guay) - Tuesday, 11 March 2008, 03:43 GMT
Afterthought: Is there any reason that some of the Debug menu items use the System Font and others don't? It might be nice for consistency's sake to have them all use the same font unless there's a good reason otherwise.
Comment by Dominik Riebeling (bluebrother) - Tuesday, 11 March 2008, 18:14 GMT
on all players with a smaller display (like Ipod Mini and smaller) the full information will only be shown if the font is rather tiny, i.e. if sysfont is used. Some screens also will look rather ugly and be harder to read if the used font isn't fixed-width, which might (and I guess will in most cases) happen when using the user font. Also, those are debug menus and IMO there is no need to have them consistent or nice (though it would be nice if it's possibly without affecting readability of the information)
Comment by Marc Guay (Marc_Guay) - Tuesday, 11 March 2008, 18:18 GMT
So there's no particular reason some of them use the user font? Why not set them all to the system font, then? Just a thought, and I realize it's totally unimportant. The font not being reset to the user font when exiting, on the other hand, still consitutes a bug.
Comment by Marc Guay (Marc_Guay) - Wednesday, 12 March 2008, 01:46 GMT
Here's a patch that makes sure the menu entries with the lcd_setfont(FONT_SYSFIXED) command return it to lcd_setfont(FONT_UI) on exit. Tested on device myself and fixes the problems I was having.
Comment by Marc Guay (Marc_Guay) - Wednesday, 12 March 2008, 02:33 GMT
Here's a patch that makes sure the menu entries with the lcd_setfont(FONT_SYSFIXED) command return it to lcd_setfont(FONT_UI) on exit. Tested on device myself and fixes the problems I was having.

Loading...